[Multiple DataSource] DataSourceSelectable support to render label by getting it from dataSourceOptions

[yujin-emma]

Description

Today the datasource menu does not populate the label of the datasource based on the datasourceId. This can be confusing to users, who may not know what human-readable datasource they are looking at.

This PR is going to resolve: when only given the dataSourceId to DataSourceSelectable, the component can get the label from existing dataSourceIdToLabel map

Issues Resolved

Screenshot

Testing the changes

test cases:

1. this is invalid case, when there is no activeOption pass in and hide local cluster, there should be a toast error

activeOption={[{id: ''}]}
hideLocalCluster={true} // need to set in the opensearc_dashboards.yml

2. there are ds options, even not pass in activeOptions, display the default options

    hideLocalCluster={true}
   

please also refer to case 9

3. do not need to take care empty array, since we do not have placeholder for DataSourceSelectable

activeOption={[]}
hideLocalCluster={true} //does not matter
// not filter out default

we do not need this case for DataSourceSelectable

4. show toast, when pass invalid dataSourceId in activeOption

selectedOption={[{id: 'invalid'}]}
hideLocalCluster={false}

5. show local cluster when pass empty string for activeOption and not hide local cluster

selectedOption={[{id: ''}]}
hideLocalCluster={false}

6. filter out default, display local cluster

 dataSourceFilter={(ds) => ds.attributes.title !== 'test1'}
        hideLocalCluster={false}

7. check when all data sources are deleted, uisetting throw error and no any datasource

hideLocalCluster={true}

8. when there is no activeOption pass in, and there is default dataSourceOption, show default dataSourceOption and show checked status on the memu

9. when there is activeOption pass in, this is the valid dataSourceOption, display it with the label it fetch from dataSourceOptions, and show checked status in the menu list
   

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.56%. Comparing base (a0eaf84) to head (0c51068).
Report is 1 commits behind head on main.

❗ Current head 0c51068 differs from pull request most recent head 12f4202. Consider uploading reports for the commit 12f4202 to get more accurate results

Files	Patch %	Lines
.../data_source_selectable/data_source_selectable.tsx	83.33%	3 Missing and 1 partial ⚠️
.../data_source_management/public/components/utils.ts	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6358   +/-   ##
=======================================
  Coverage   67.56%   67.56%           
=======================================
  Files        3379     3379           
  Lines       65894    65897    +3     
  Branches    10660    10655    -5     
=======================================
+ Hits        44522    44526    +4     
- Misses      18774    18776    +2     
+ Partials     2598     2595    -3     

Flag	Coverage Δ
Linux_1	32.63% <ø> (ø)
Linux_2	55.62% <ø> (ø)
Linux_3	45.00% <84.84%> (-0.01%)	⬇️
Linux_4	34.98% <0.00%> (-0.01%)	⬇️
Windows_1	32.65% <ø> (ø)
Windows_2	55.58% <ø> (ø)
Windows_3	45.01% <84.84%> (+<0.01%)	⬆️
Windows_4	34.98% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BionIT]

3. show default when pass in empty array for activeOption
   activeOption={[]}
   hideLocalCluster={true} //does not matter
   // not filter out default

Can we double check the test case 3? Based on the implementation, it should not be the case

[yujin-emma]

synced with @BionIT offline, we do not need to take care this case in DataSourceSelectable, since we do not have a placeholder

[BionIT]

same here, is this for debugging? can we remove?

[BionIT]

same here, is this for debugging? can we remove?

[BionIT]

I thought we need this union type since we set it like const defaultDataSource = this.props.uiSettings?.get('defaultDataSource', null) ?? null;

[ZilongX]

LGTM, rerunning skipped ciGroup5 before merging into main