[Workspace]Feat add use cases to workspace form by wanglam · Pull Request #6887 · opensearch-project/OpenSearch-Dashboards

wanglam · 2024-06-03T07:23:55Z

Description

Add use case selector to workspace form
Remove workspace feature selector
Add use workspace column in workspace list

Issues Resolved

Screenshot

Testing the changes

Clone branch code and run yarn osd bootstrap
Add below configuration to config/opensearch_dashboards.yml

opensearchDashboards.dashboardAdmin.users: ['admin']
workspace.enabled: true

Login with admin user and visit workspace create page
Input name and select one or multi use cases
Click create workspace, then name and use cases will be saved
Click left menu, the related features will be displayed.

Changelog

feat: [Workspace]Add use cases to workspace form

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>

github-actions · 2024-06-03T07:24:30Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-06-03T07:38:43Z

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.43%. Comparing base (fe443e9) to head (4caf213).
Report is 394 commits behind head on main.

Files with missing lines	Patch %	Lines
...rkspace/public/components/workspace_list/index.tsx	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6887   +/-   ##
=======================================
  Coverage   67.42%   67.43%           
=======================================
  Files        3445     3445           
  Lines       67827    67818    -9     
  Branches    11036    11028    -8     
=======================================
- Hits        45735    45732    -3     
+ Misses      19424    19420    -4     
+ Partials     2668     2666    -2

Flag	Coverage Δ
Linux_1	`33.08% <98.41%> (-0.01%)`	⬇️
Linux_2	`55.06% <ø> (ø)`
Linux_3	`45.21% <ø> (?)`
Linux_4	`34.87% <ø> (ø)`
Windows_1	`33.10% <98.41%> (-0.01%)`	⬇️
Windows_2	`55.01% <ø> (ø)`
Windows_3	`45.22% <ø> (ø)`
Windows_4	`34.87% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lin Wang <wonglam@amazon.com>

BionIT · 2024-06-03T16:47:59Z

Hi @wanglam, is this PR targeting 2.15 or 2.16?

wanglam · 2024-06-04T01:17:37Z

Hi @BionIT , this PR is target for 2.15. Since this PR still need UX approve. I will change to ready for review once UX finalized.

Signed-off-by: Lin Wang <wonglam@amazon.com>

lauralexis · 2024-06-06T14:30:00Z

@wanglam UX looks good to me

wanglam · 2024-06-06T14:32:17Z

Hi @Flyingliuhub @ruanyl @SuZhou-Joe , I've updated the latest UI and addressed the comments. Could you help me take a look?

SuZhou-Joe · 2024-06-06T22:33:49Z

@wanglam seems the test failed for snapshot checking. Could you please fix that?

Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam · 2024-06-07T03:15:41Z

@wanglam seems the test failed for snapshot checking. Could you please fix that?

@SuZhou-Joe Thanks for point out this. I've fixed all the test failed. Feel free to help me review it.

* Add workspace use case to workspace form Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove feature selector in workspace form Signed-off-by: Lin Wang <wonglam@amazon.com> * Show use cases in workspace list page Signed-off-by: Lin Wang <wonglam@amazon.com> * Change direction for workspace use case selector Signed-off-by: Lin Wang <wonglam@amazon.com> * Modify test cases for match use case Signed-off-by: Lin Wang <wonglam@amazon.com> * Make use cases as a required field Signed-off-by: Lin Wang <wonglam@amazon.com> * Update ui according feedbacks Signed-off-by: Lin Wang <wonglam@amazon.com> * Add management feature to dashboards and visualize use cases Signed-off-by: Lin Wang <wonglam@amazon.com> * Update latest feature relationships Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #6887 created/updated * Changeset file for PR #6887 created/updated * Update test case for workspace creator and updater Signed-off-by: Lin Wang <wonglam@amazon.com> * Address unit test Signed-off-by: Lin Wang <wonglam@amazon.com> * Add discover feature to all use case Signed-off-by: Lin Wang <wonglam@amazon.com> * Add missing features to security analytics Signed-off-by: Lin Wang <wonglam@amazon.com> * Address PR comments Signed-off-by: Lin Wang <wonglam@amazon.com> * Add comment for workspace use cases map Signed-off-by: Lin Wang <wonglam@amazon.com> * Update use case UI Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove the permissions tab Signed-off-by: Lin Wang <wonglam@amazon.com> * Update breadcrum to Create a workspace Signed-off-by: Lin Wang <wonglam@amazon.com> * Address ut failed Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 7be3e30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add workspace use case to workspace form * Remove feature selector in workspace form * Show use cases in workspace list page * Change direction for workspace use case selector * Modify test cases for match use case * Make use cases as a required field * Update ui according feedbacks * Add management feature to dashboards and visualize use cases * Update latest feature relationships * Changeset file for PR #6887 created/updated * Changeset file for PR #6887 created/updated * Update test case for workspace creator and updater * Address unit test * Add discover feature to all use case * Add missing features to security analytics * Address PR comments * Add comment for workspace use cases map * Update use case UI * Remove the permissions tab * Update breadcrum to Create a workspace * Address ut failed --------- (cherry picked from commit 7be3e30) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>

wanglam added 9 commits June 3, 2024 15:16

Add workspace use case to workspace form

d27b2f2

Signed-off-by: Lin Wang <wonglam@amazon.com>

Remove feature selector in workspace form

81f069a

Signed-off-by: Lin Wang <wonglam@amazon.com>

Show use cases in workspace list page

2db0264

Signed-off-by: Lin Wang <wonglam@amazon.com>

Change direction for workspace use case selector

2463602

Signed-off-by: Lin Wang <wonglam@amazon.com>

Modify test cases for match use case

0c3991d

Signed-off-by: Lin Wang <wonglam@amazon.com>

Make use cases as a required field

a9cc376

Signed-off-by: Lin Wang <wonglam@amazon.com>

Update ui according feedbacks

136c9db

Signed-off-by: Lin Wang <wonglam@amazon.com>

Add management feature to dashboards and visualize use cases

e0f624c

Signed-off-by: Lin Wang <wonglam@amazon.com>

Update latest feature relationships

47ca6f7

Signed-off-by: Lin Wang <wonglam@amazon.com>

github-actions bot added the valued-contributor label Jun 3, 2024

github-actions bot added the failed changeset label Jun 3, 2024

Changeset file for PR opensearch-project#6887 created/updated

bafdc05

github-actions bot removed the failed changeset label Jun 3, 2024

wanglam changed the title ~~Feat add use cases to workspace form~~ [Workspace]Feat add use cases to workspace form Jun 3, 2024

opensearch-changeset-bot bot and others added 2 commits June 3, 2024 09:03

Changeset file for PR opensearch-project#6887 created/updated

e3f2756

Update test case for workspace creator and updater

dc2f49e

Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam added 3 commits June 4, 2024 11:43

Address unit test

a597f59

Signed-off-by: Lin Wang <wonglam@amazon.com>

Add discover feature to all use case

f3e52ca

Signed-off-by: Lin Wang <wonglam@amazon.com>

Add missing features to security analytics

8f6f45b

Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam marked this pull request as ready for review June 5, 2024 02:04

wanglam requested review from AMoo-Miki, abbyhu2000, ananzh, ashwin-pc, joshuarrrr and kavilla as code owners June 5, 2024 02:04

ruanyl previously approved these changes Jun 6, 2024

View reviewed changes

SuZhou-Joe previously approved these changes Jun 6, 2024

View reviewed changes

wanglam added 4 commits June 6, 2024 22:09

Add comment for workspace use cases map

1565a01

Signed-off-by: Lin Wang <wonglam@amazon.com>

Update use case UI

55e9839

Signed-off-by: Lin Wang <wonglam@amazon.com>

Remove the permissions tab

9cfa436

Signed-off-by: Lin Wang <wonglam@amazon.com>

Update breadcrum to Create a workspace

9bc93db

Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam dismissed stale reviews from SuZhou-Joe and ruanyl via 9bc93db June 6, 2024 14:11

Flyingliuhub previously approved these changes Jun 6, 2024

View reviewed changes

wanglam added 2 commits June 7, 2024 09:39

Merge branch 'main' into feat-add-use-cases-to-workspace-form

adc2b54

Signed-off-by: Lin Wang <wonglam@amazon.com>

Address ut failed

4caf213

Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam dismissed Flyingliuhub’s stale review via 4caf213 June 7, 2024 01:41

ruanyl approved these changes Jun 7, 2024

View reviewed changes

SuZhou-Joe approved these changes Jun 7, 2024

View reviewed changes

ruanyl added the workspace label Jun 7, 2024

SuZhou-Joe merged commit 7be3e30 into opensearch-project:main Jun 7, 2024

opensearch-trigger-bot bot added the failed backport label Jun 7, 2024

SuZhou-Joe added backport 2.x and removed backport 2.x failed backport labels Jun 7, 2024

opensearch-project deleted a comment from opensearch-trigger-bot bot Jun 7, 2024

opensearch-trigger-bot bot mentioned this pull request Jun 7, 2024

[Backport 2.x] [Workspace]Feat add use cases to workspace form #6967

Merged

wanglam mentioned this pull request Aug 14, 2024

[Workspace]Add features list to use case card and preselect first one #7705

Closed

AMoo-Miki added the in-next label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace]Feat add use cases to workspace form#6887

[Workspace]Feat add use cases to workspace form#6887
SuZhou-Joe merged 25 commits intoopensearch-project:mainfrom
wanglam:feat-add-use-cases-to-workspace-form

wanglam commented Jun 3, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jun 3, 2024

Uh oh!

codecov bot commented Jun 3, 2024 •

edited

Loading

Uh oh!

BionIT commented Jun 3, 2024

Uh oh!

wanglam commented Jun 4, 2024

Uh oh!

lauralexis commented Jun 6, 2024

Uh oh!

wanglam commented Jun 6, 2024

Uh oh!

SuZhou-Joe commented Jun 6, 2024

Uh oh!

wanglam commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

wanglam commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

Uh oh!

github-actions bot commented Jun 3, 2024

❌ Empty Changelog Section

Uh oh!

codecov bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

BionIT commented Jun 3, 2024

Uh oh!

wanglam commented Jun 4, 2024

Uh oh!

lauralexis commented Jun 6, 2024

Uh oh!

wanglam commented Jun 6, 2024

Uh oh!

SuZhou-Joe commented Jun 6, 2024

Uh oh!

wanglam commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wanglam commented Jun 3, 2024 •

edited

Loading

codecov bot commented Jun 3, 2024 •

edited

Loading