Use JSON11 for handling long numerals#6915
Conversation
AMoo-Miki
requested review from
BionIT,
Flyingliuhub,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
| dependencies: | ||
| yallist "^4.0.0" | ||
|
|
||
| minipass@^4.0.0: |
There was a problem hiding this comment.
This was probably left off of another PR.
There was a problem hiding this comment.
need to rebase? or do you mean like we merged this and it shouldn't be there?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6915 +/- ##
==========================================
- Coverage 67.44% 67.44% -0.01%
==========================================
Files 3444 3444
Lines 67849 67781 -68
Branches 11035 11023 -12
==========================================
- Hits 45764 45714 -50
+ Misses 19418 19401 -17
+ Partials 2667 2666 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Miki <miki@amazon.com>
| }, | ||
| "dependencies": { | ||
| "@opensearch-project/opensearch": "^2.6.0", | ||
| "@opensearch-project/opensearch": "^2.9.0", |
There was a problem hiding this comment.
Nit: Is it necessary we upgrade the client version?
There was a problem hiding this comment.
Yeah. We need the version that uses JSON11
❌ Changeset File Must Not Exist With Skip EntryChangeset file 6915.yml under folder changelogs/fragments must not exist if ##Changelog section in PR description includes a "skip" entry option. Please remove the changeset file and try again. |
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| /* In JavaScript, a `Number` is a 64-bit floating-point value which can store 16 digits. However, the |
kavilla
left a comment
kavilla
left a comment
There was a problem hiding this comment.
do you think we should run through the closed issues related to the other issues related to long numerals?
thinking we could probably open an issue like 'automate verifying these closed issues?'. i feel like it's particularily perf testing when we see these issues right?
|
oh weird i see a changelog fragment but i see skip in the pr description. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6915-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a2074249c92ec204bb7edff72f93a641da1385e
# Push it to GitHub
git push --set-upstream origin backport/backport-6915-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 6a20742) Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 6a20742) Signed-off-by: Miki <miki@amazon.com>
|
Hi @AMoo-Miki This PR has failed backport, could you help to manual backport? |
(cherry picked from commit 6a20742) Signed-off-by: Miki <miki@amazon.com>
…search-project#6970) (cherry picked from commit 6a20742) Signed-off-by: Miki <miki@amazon.com>
5 participants
Description
Replaces the custom regex-based logic with an AST-based one from JSON11. Handling a sample that created 10K false-positives went from 90s to 200ms.
Issues Resolved
Fixes #6377
Changelog
Check List
yarn test:jestyarn test:jest_integration