Skip to content

[MDS] Fix the dsm plugin setup when mds feature flag is disabled#7163

Merged
mengweieric merged 2 commits intoopensearch-project:mainfrom
RyanL1997:dsm-registration-fix-main
Jul 3, 2024
Merged

[MDS] Fix the dsm plugin setup when mds feature flag is disabled#7163
mengweieric merged 2 commits intoopensearch-project:mainfrom
RyanL1997:dsm-registration-fix-main

Conversation

@RyanL1997
Copy link
Copy Markdown
Contributor

@RyanL1997 RyanL1997 commented Jul 2, 2024 •
edited
Loading

Description

Fix the dsm plugin setup when mds feature flag is disabled

Issues Resolved

#7143 introduced the behavior that Data source management plugin will always be registered, and this PR introduced the proper handling of DSM plugin setup when data_source.enabled is set to false.

Changelog

  • fix: [MDS] Fix the dsm plugin setup when mds feature flag is disabled

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 2, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

opensearch-changeset-bot bot added a commit to RyanL1997/OpenSearch-Dashboards that referenced this pull request Jul 2, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7163 created/updated
dd90833
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (daccab7) to head (c58b513).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/plugins/data_source_management/public/plugin.ts 72.72% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7163      +/-   ##
==========================================
+ Coverage   67.48%   67.51%   +0.02%     
==========================================
  Files        3468     3468              
  Lines       68375    68375              
  Branches    11114    11113       -1     
==========================================
+ Hits        46146    46162      +16     
+ Misses      19529    19516      -13     
+ Partials     2700     2697       -3
Flag Coverage Δ
Linux_1 33.05% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_3 45.35% <72.72%> (+0.01%) ⬆️
Linux_4 34.76% <0.00%> (ø)
Windows_1 33.09% <ø> (+0.02%) ⬆️
Windows_2 55.14% <ø> (ø)
Windows_3 45.37% <72.72%> (+0.01%) ⬆️
Windows_4 34.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997 RyanL1997 force-pushed the dsm-registration-fix-main branch from a9ec9c1 to c58b513 Compare July 2, 2024 23:55
@RyanL1997 RyanL1997 marked this pull request as ready for review July 3, 2024 00:14
@RyanL1997 RyanL1997 mentioned this pull request Jul 3, 2024
Merged
3 tasks
@mengweieric mengweieric merged commit 0cc2b99 into opensearch-project:main Jul 3, 2024
RyanL1997 added a commit to RyanL1997/OpenSearch-Dashboards that referenced this pull request Jul 22, 2024
@RyanL1997 @opensearch-changeset-bot
[MDS] Fix the dsm plugin setup when mds feature flag is disabled (ope…
5e51914 
…nsearch-project#7163)

* Fix the dsm plugin setup when mds feature flag is disabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR opensearch-project#7163 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@RyanL1997 RyanL1997 mentioned this pull request Jul 22, 2024
Merged
7 tasks
BionIT pushed a commit that referenced this pull request Jul 22, 2024
@RyanL1997 @opensearch-changeset-bot
[Backport 2.x][MDS] Observability Datasource Plugin migration with MD…
704f2fa 
…S support for Data Connection Table (#7371)

* [MDS] Observability Datasource Plugin migration with MDS support (#7143)

* Observability Datasource Plugin migration with MDS support

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Switch to use doc services for doc links of configuration of s3 datasource

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for home panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the snapshot for mds

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for data source creation panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq data connection table

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq configuration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add readonly for s3glue doc link

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for s3 prometheus creation and review

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix mount feature flag behavior and tests

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names again

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Experiment 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the visbuilder failure 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the setter of datasource setup in vis_type_timeseries

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Synced branch

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the readonly in doc link and add change log

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the create opensearch datasource's cancel button redirection

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add more test cases for breadscrumb changes and mount behavior based on the plugin registration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163)

* Fix the dsm plugin setup when mds feature flag is disabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7163 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* Changeset file for PR #7371 created/updated

* Fix snapshots

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions @opensearch-changeset-bot
[Backport 2.x][MDS] Observability Datasource Plugin migration with MD…
9eb1896 
…S support for Data Connection Table (#7371)

* [MDS] Observability Datasource Plugin migration with MDS support (#7143)

* Observability Datasource Plugin migration with MDS support

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Switch to use doc services for doc links of configuration of s3 datasource

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for home panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the snapshot for mds

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for data source creation panel

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq data connection table

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for dq configuration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add readonly for s3glue doc link

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add tests for s3 prometheus creation and review

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix mount feature flag behavior and tests

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Shorten file names again

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Experiment 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the visbuilder failure 1

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the setter of datasource setup in vis_type_timeseries

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Synced branch

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the readonly in doc link and add change log

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the create opensearch datasource's cancel button redirection

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add more test cases for breadscrumb changes and mount behavior based on the plugin registration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163)

* Fix the dsm plugin setup when mds feature flag is disabled

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7163 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* Changeset file for PR #7371 created/updated

* Fix snapshots

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 704f2fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Backport 2.x][MDS] Observability Datasource Plugin migration with MD…
a9fd071 
…S support for Data Connection Table (#7371) (#7384)

* [MDS] Observability Datasource Plugin migration with MDS support (#7143)

* Observability Datasource Plugin migration with MDS support



* Switch to use doc services for doc links of configuration of s3 datasource



* Add tests for home panel



* Fix the snapshot for mds



* Add tests for data source creation panel



* Add tests for dq data connection table



* Add tests for dq configuration



* Add readonly for s3glue doc link



* Add tests for s3 prometheus creation and review



* Fix mount feature flag behavior and tests



* Shorten file names



* Shorten file names again



* Experiment 1



* Fix the visbuilder failure 1



* Fix the setter of datasource setup in vis_type_timeseries



* Synced branch



* Fix the readonly in doc link and add change log



* Fix the create opensearch datasource's cancel button redirection



* Add more test cases for breadscrumb changes and mount behavior based on the plugin registration



---------



* [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163)

* Fix the dsm plugin setup when mds feature flag is disabled



* Changeset file for PR #7163 created/updated

---------




* Changeset file for PR #7371 created/updated

* Fix snapshots



---------



(cherry picked from commit 704f2fa)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mengweieric mengweieric mengweieric approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

+1 more reviewer

@BionIT BionIT BionIT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

repeat-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] data_source.enabled: false causes getDataSourceMenu to fail

3 participants

@RyanL1997 @BionIT @mengweieric
⚡