[navigation-next] Add new left navigation by SuZhou-Joe · Pull Request #7230 · opensearch-project/OpenSearch-Dashboards

SuZhou-Joe · 2024-07-12T09:17:56Z

Description

Register apps within core to navGroup.
Enable new left navigation.

Issues Resolved

closes #7148
closes #7094

Screenshot

data source enabled / new navigation enabled

20240717154041829.mp4

data source enabled / new navigation disabled

20240717183614054.mp4

data source disabled / new navigation enabled

20240717155424312.mp4

data source disabled / new navigation disabled

20240717155203221.mp4

Testing the changes

Go to advanced settings to enable new home page config.
Navigate around by using the new left navigation.

Changelog

feat: [navigation-next] Add new left navigation

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…e_service.(opensearch-project#7093) Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe · 2024-07-17T15:00:12Z

Build and Verify on Linux (ciGroup4) failed because of #7057

ruanyl

Amazing changes, code looks good to me, since we already discussed the design quite a lot, I'm approving now!

ruanyl · 2024-07-18T05:25:35Z

+      return 50;
+    }
+
+    return 270;


Nit: avoid magic number

BionIT · 2024-07-18T05:32:33Z

+  navLinks: ChromeNavLink[];
+  suffix?: React.ReactElement;
+  style?: React.CSSProperties;
+  appId?: string;


should optional props be at the end?

BionIT · 2024-07-18T05:36:31Z

+    if (navLink.itemType === LinkItemType.CATEGORY) {
+      return {
+        id: navLink.category?.id ?? '',
+        name: <div className="nav-link-item">{navLink.category?.label ?? ''}</div>,


can category be empty label and id?

BionIT · 2024-07-18T05:39:48Z

+
+  const width = useMemo(() => {
+    if (!isNavOpen) {
+      return 50;


instead of using magic number, can we give it a name, is it percentage or other unit?

Sure, will optimize this part.

BionIT · 2024-07-18T05:42:37Z

+import { Observable } from 'rxjs';
+import { DEFAULT_NAV_GROUPS, NavGroupItemInMap } from '../../../../core/public';
+
+export function SettingsIcon({ core }: { core: CoreStart }) {


is this component covered by test?

opensearch-trigger-bot · 2024-07-18T07:27:52Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7230-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 38ae65b22c7f9d5bc7f18669489574d90a4ee9fe
# Push it to GitHub
git push --set-upstream origin backport/backport-7230-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7230-to-2.x.

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(opensearch-project#7093) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable parent nav link id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify style Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable left bottom Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp: merge Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: merge Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: overview page can not be load Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: new application Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update category based on latest design Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: do not emphasize see all link Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#7230 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093) * feat: enable parent nav link id * feat: modify left navigation * feat: modify style * feat: enable left bottom * temp: merge * feat: save * feat: merge * temp change * temp change * fix: overview page can not be load * feat: remove useless change * feat: add unit test * feat: update snapshot * fix: unit test error * fix: new application * feat: add unit test * feat: update category based on latest design * feat: update * feat: update snapshot * feat: do not emphasize see all link * Changeset file for PR #7230 created/updated * feat: update * feat: update --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093) * feat: enable parent nav link id * feat: modify left navigation * feat: modify style * feat: enable left bottom * temp: merge * feat: save * feat: merge * temp change * temp change * fix: overview page can not be load * feat: remove useless change * feat: add unit test * feat: update snapshot * fix: unit test error * fix: new application * feat: add unit test * feat: update category based on latest design * feat: update * feat: update snapshot * feat: do not emphasize see all link * Changeset file for PR #7230 created/updated * feat: update * feat: update --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b28aa98) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [navigation-next] Add CollapsibleNavGroupEnabled component into chrome_service.(#7093) * feat: enable parent nav link id * feat: modify left navigation * feat: modify style * feat: enable left bottom * temp: merge * feat: save * feat: merge * temp change * temp change * fix: overview page can not be load * feat: remove useless change * feat: add unit test * feat: update snapshot * fix: unit test error * fix: new application * feat: add unit test * feat: update category based on latest design * feat: update * feat: update snapshot * feat: do not emphasize see all link * Changeset file for PR #7230 created/updated * feat: update * feat: update --------- (cherry picked from commit b28aa98) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

SuZhou-Joe added 11 commits July 3, 2024 17:04

[navigation-next] Add CollapsibleNavGroupEnabled component into chrom…

82307c5

…e_service.(opensearch-project#7093) Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: enable parent nav link id

4089a63

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: modify left navigation

1e13a69

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: modify style

899240b

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: enable left bottom

b9c9a77

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

temp: merge

175e880

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: save

0106c19

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: merge

09245b6

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

temp change

f300020

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

temp change

ff9a257

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

temp change

186895c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe requested review from AMoo-Miki, BionIT, Flyingliuhub, LDrago27, ZilongX, abbyhu2000, ananzh, ashwin-pc, bandinib-amzn, curq, joshuarrrr, kavilla, manasvinibs, mengweieric, ruanyl, xinruiba, zengyan-amazon, zhongnansu and zhyuanqi as code owners July 12, 2024 09:17

opensearch-project deleted a comment from github-actions bot Jul 17, 2024

Changeset file for PR opensearch-project#7230 created/updated

3fc83eb

github-actions bot removed the failed changeset label Jul 17, 2024

opensearch-project deleted a comment from github-actions bot Jul 17, 2024

feat: update

45d1158

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

opensearch-project deleted a comment from github-actions bot Jul 17, 2024

feat: update

e63e013

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe added the backport 2.x label Jul 17, 2024

ruanyl approved these changes Jul 18, 2024

View reviewed changes

BionIT reviewed Jul 18, 2024

View reviewed changes

BionIT approved these changes Jul 18, 2024

View reviewed changes

SuZhou-Joe merged commit 38ae65b into opensearch-project:main Jul 18, 2024

opensearch-trigger-bot bot added the failed backport label Jul 18, 2024

SuZhou-Joe mentioned this pull request Jul 18, 2024

[Backport 2.x][navigation-next] Add new left navigation (#7230) #7300

Merged

7 tasks

SuZhou-Joe mentioned this pull request Jul 18, 2024

[Backport 2.x][navigation-next] Add new left navigation (#7230) #7301

Merged

yenienserrano mentioned this pull request Aug 19, 2024

Compatibility with OpenSearch 2.16.0 wazuh/wazuh-dashboard#265

Closed

5 tasks

AMoo-Miki removed the failed backport label Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[navigation-next] Add new left navigation#7230

[navigation-next] Add new left navigation#7230
SuZhou-Joe merged 28 commits intoopensearch-project:mainfrom
SuZhou-Joe:feature/add-register-left-interface

SuZhou-Joe commented Jul 12, 2024 •

edited

Loading

Uh oh!

SuZhou-Joe commented Jul 17, 2024

Uh oh!

ruanyl left a comment

Uh oh!

ruanyl Jul 18, 2024

Uh oh!

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Uh oh!

SuZhou-Joe Jul 18, 2024

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Uh oh!

Uh oh!

opensearch-trigger-bot bot commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

SuZhou-Joe commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Screenshot

data source enabled / new navigation enabled

data source enabled / new navigation disabled

data source disabled / new navigation enabled

data source disabled / new navigation disabled

Testing the changes

Changelog

Check List

Uh oh!

SuZhou-Joe commented Jul 17, 2024

Uh oh!

ruanyl left a comment

Choose a reason for hiding this comment

Uh oh!

ruanyl Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

SuZhou-Joe Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BionIT Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

opensearch-trigger-bot bot commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SuZhou-Joe commented Jul 12, 2024 •

edited

Loading