New Query Enhancement UI#7309
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7309 +/- ##
=======================================
Coverage 67.53% 67.53%
=======================================
Files 3504 3504
Lines 69407 69418 +11
Branches 11324 11327 +3
=======================================
+ Hits 46872 46881 +9
- Misses 19775 19777 +2
Partials 2760 2760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
21c1a35 to
6e6ff41
Compare
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ashwin-pc
left a comment
There was a problem hiding this comment.
Nice, this gets the framework in. Since we have gone the custom route, lets clean up the styles to make the fit and finish better.
| */ | ||
| getBanner?: (dependencies: QueryEditorExtensionDependencies) => React.ReactElement | null; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: Think you might have unintentionally deleted this line
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7309-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f955faa37d78ffad09b6902da4a1f900d4616a94
# Push it to GitHub
git push --set-upstream origin backport/backport-7309-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7309-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f955faa37d78ffad09b6902da4a1f900d4616a94
# Push it to GitHub
git push --set-upstream origin backport/backport-7309-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
* UI changes Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * update snapshots Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correct license Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * more cleanup Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * more styling and update snapshots Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
…t#7457) * UI changes * update snapshots * styling * correct license * more cleanup * more styling and update snapshots --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Description
New query enhancement UI.
Issues Resolved
#7038
Screenshot
Screen.Recording.2024-07-18.at.2.35.01.PM.mov
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration