[Navigation-next] Enrich breadcrumbs by workspace and use case#7360
Merged
ruanyl merged 4 commits intoopensearch-project:mainfrom Jul 23, 2024
Merged
[Navigation-next] Enrich breadcrumbs by workspace and use case#7360ruanyl merged 4 commits intoopensearch-project:mainfrom
ruanyl merged 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7360 +/- ##
==========================================
+ Coverage 67.70% 67.72% +0.01%
==========================================
Files 3520 3520
Lines 69700 69752 +52
Branches 11376 11388 +12
==========================================
+ Hits 47189 47237 +48
- Misses 19716 19719 +3
- Partials 2795 2796 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jul 22, 2024
| export function HeaderBreadcrumbs({ appTitle$, breadcrumbs$, breadcrumbsEnricher$ }: Props) { | ||
| const appTitle = useObservable(appTitle$, 'OpenSearch Dashboards'); | ||
| const breadcrumbs = useObservable(breadcrumbs$, []); | ||
| const [breadcrumbEnricher, setBreadcrumbEnricher] = useState< |
Member
There was a problem hiding this comment.
useObservable should be good enough give the enriched value.
Collaborator
Author
There was a problem hiding this comment.
as the enricher is a function, setBreadcrumbEnricher will call/execute the function automatically, that's why to use useEffect + useState and change default behavior to below. cc @wanglam
const sub = breadcrumbsEnricher$.subscribe((enricher) => {
setBreadcrumbEnricher(() => enricher);
});
Member
There was a problem hiding this comment.
Can't we just do useObservable(breadcrumbsEnricher$)?
ruanyl
approved these changes
Jul 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* breadcrumbs for workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7360 created/updated * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 7ff8544) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* breadcrumbs for workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7360 created/updated * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 7ff8544) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Jul 23, 2024
#7392) * breadcrumbs for workspace * add unit test * Changeset file for PR #7360 created/updated * add unit test --------- (cherry picked from commit 7ff8544) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Jul 23, 2024
#7393) * breadcrumbs for workspace * add unit test * Changeset file for PR #7360 created/updated * add unit test --------- (cherry picked from commit 7ff8544) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#7359
Screenshot
in workspace
workspace with all use case
workspace disabled
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration