[navigation]fix: add sample data to left navigation#7613
Merged
BionIT merged 3 commits intoopensearch-project:mainfrom Aug 2, 2024
Merged
[navigation]fix: add sample data to left navigation#7613BionIT merged 3 commits intoopensearch-project:mainfrom
BionIT merged 3 commits intoopensearch-project:mainfrom
Conversation
SuZhou-Joe
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
opensearch-changeset-bot bot
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 2, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
feature/add-sample-data
branch
from
bef51e6 to
c39bae4
Compare
SuZhou-Joe
changed the title
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7613 +/- ##
==========================================
- Coverage 63.65% 63.65% -0.01%
==========================================
Files 3632 3632
Lines 80056 80060 +4
Branches 12682 12683 +1
==========================================
+ Hits 50962 50963 +1
- Misses 25990 25991 +1
- Partials 3104 3106 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BionIT
approved these changes
Aug 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* feat: add sample data to left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7613 created/updated * feat: add sample data to left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 352d2e9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* feat: add sample data to left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7613 created/updated * feat: add sample data to left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 352d2e9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 2, 2024
* feat: add sample data to left navigation * Changeset file for PR #7613 created/updated * feat: add sample data to left navigation --------- (cherry picked from commit 352d2e9) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 2, 2024
* feat: add sample data to left navigation * Changeset file for PR #7613 created/updated * feat: add sample data to left navigation --------- (cherry picked from commit 352d2e9) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We lost sample data in the design of new left navigation and this PR is trying to bring it back because import sample data is a very useful feature in OSD to quickly setup some dashboards and visualizations.
Issues Resolved
Screenshot
Before fix
After fix
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration