Simplify TopNavControlDescriptionData to to be followed by links#7723
Merged
AMoo-Miki merged 2 commits intoopensearch-project:mainfrom Aug 15, 2024
Merged
Simplify TopNavControlDescriptionData to to be followed by links#7723AMoo-Miki merged 2 commits intoopensearch-project:mainfrom
TopNavControlDescriptionData to to be followed by links#7723AMoo-Miki merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7723 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 3651 3651
Lines 80953 80955 +2
Branches 12886 12887 +1
=======================================
+ Hits 51665 51667 +2
Misses 26124 26124
Partials 3164 3164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Build and Verify CI 1 failure is related to a bad PR being merged: #7699 |
abbyhu2000
approved these changes
Aug 15, 2024
virajsanghvi
approved these changes
Aug 15, 2024
Collaborator
virajsanghvi
left a comment
virajsanghvi
left a comment
There was a problem hiding this comment.
Approving assuming test failures are unrelated
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
…7723) * Simplify `TopNavControlDescriptionData` to to be followed by links Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #7723 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d447c5d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 19, 2024
…7723) (#7724) * Simplify `TopNavControlDescriptionData` to to be followed by links * Changeset file for PR #7723 created/updated --------- (cherry picked from commit d447c5d) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify
TopNavControlDescriptionDatato to be followed by linksChangelog
TopNavControlDescriptionDatato to be followed by linksCheck List
yarn test:jestyarn test:jest_integration