[Workspace]Add right sidebar to workspace create form#7750
Merged
SuZhou-Joe merged 9 commits intoopensearch-project:mainfrom Aug 30, 2024
Merged
Conversation
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Aug 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7750 +/- ##
==========================================
+ Coverage 64.30% 64.32% +0.02%
==========================================
Files 3674 3676 +2
Lines 81138 81185 +47
Branches 12927 12943 +16
==========================================
+ Hits 52174 52222 +48
+ Misses 25752 25751 -1
Partials 3212 3212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Aug 22, 2024
5eca186 to
1278a74
Compare
ruanyl
previously approved these changes
Aug 23, 2024
Comment on lines
+39
to
+70
| return { | ||
| [RightSidebarScrollField.UseCase]: i18n.translate( | ||
| 'workspace.form.summary.panel.useCase.title', | ||
| { | ||
| defaultMessage: 'Use case', | ||
| } | ||
| ), | ||
| [RightSidebarScrollField.Name]: i18n.translate('workspace.form.summary.panel.name.title', { | ||
| defaultMessage: 'Name', | ||
| }), | ||
| [RightSidebarScrollField.Description]: i18n.translate( | ||
| 'workspace.form.summary.panel.description.title', | ||
| { | ||
| defaultMessage: 'Description', | ||
| } | ||
| ), | ||
| [RightSidebarScrollField.Color]: i18n.translate('workspace.form.summary.panel.color.title', { | ||
| defaultMessage: 'Accent color', | ||
| }), | ||
| [RightSidebarScrollField.DataSource]: i18n.translate( | ||
| 'workspace.form.summary.panel.dataSources.title', | ||
| { | ||
| defaultMessage: 'Data sources', | ||
| } | ||
| ), | ||
| [RightSidebarScrollField.Member]: i18n.translate( | ||
| 'workspace.form.summary.panel.members.title', | ||
| { | ||
| defaultMessage: 'Members', | ||
| } | ||
| ), | ||
| }[field]; |
Member
There was a problem hiding this comment.
Nit: maybe can just make it a constant, then use it at where it's needed with SCROLL_FIELDS[field]
Suggested change
| return { | |
| [RightSidebarScrollField.UseCase]: i18n.translate( | |
| 'workspace.form.summary.panel.useCase.title', | |
| { | |
| defaultMessage: 'Use case', | |
| } | |
| ), | |
| [RightSidebarScrollField.Name]: i18n.translate('workspace.form.summary.panel.name.title', { | |
| defaultMessage: 'Name', | |
| }), | |
| [RightSidebarScrollField.Description]: i18n.translate( | |
| 'workspace.form.summary.panel.description.title', | |
| { | |
| defaultMessage: 'Description', | |
| } | |
| ), | |
| [RightSidebarScrollField.Color]: i18n.translate('workspace.form.summary.panel.color.title', { | |
| defaultMessage: 'Accent color', | |
| }), | |
| [RightSidebarScrollField.DataSource]: i18n.translate( | |
| 'workspace.form.summary.panel.dataSources.title', | |
| { | |
| defaultMessage: 'Data sources', | |
| } | |
| ), | |
| [RightSidebarScrollField.Member]: i18n.translate( | |
| 'workspace.form.summary.panel.members.title', | |
| { | |
| defaultMessage: 'Members', | |
| } | |
| ), | |
| }[field]; | |
| const SCROLL_FIELDS = { | |
| [RightSidebarScrollField.UseCase]: i18n.translate( | |
| 'workspace.form.summary.panel.useCase.title', | |
| { | |
| defaultMessage: 'Use case', | |
| } | |
| ), | |
| [RightSidebarScrollField.Name]: i18n.translate('workspace.form.summary.panel.name.title', { | |
| defaultMessage: 'Name', | |
| }), | |
| [RightSidebarScrollField.Description]: i18n.translate( | |
| 'workspace.form.summary.panel.description.title', | |
| { | |
| defaultMessage: 'Description', | |
| } | |
| ), | |
| [RightSidebarScrollField.Color]: i18n.translate('workspace.form.summary.panel.color.title', { | |
| defaultMessage: 'Accent color', | |
| }), | |
| [RightSidebarScrollField.DataSource]: i18n.translate( | |
| 'workspace.form.summary.panel.dataSources.title', | |
| { | |
| defaultMessage: 'Data sources', | |
| } | |
| ), | |
| [RightSidebarScrollField.Member]: i18n.translate( | |
| 'workspace.form.summary.panel.members.title', | |
| { | |
| defaultMessage: 'Members', | |
| } | |
| ), | |
| }; |
Collaborator
Author
There was a problem hiding this comment.
Looks good to me, will update.
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Aug 28, 2024
8e1f1e9 to
60d235b
Compare
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Aug 28, 2024
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Aug 28, 2024
60d235b to
fc002b0
Compare
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
fc002b0 to
6294070
Compare
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl
approved these changes
Aug 30, 2024
SuZhou-Joe
approved these changes
Aug 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Move workspace form inside workspace creator Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove enter details panel Signed-off-by: Lin Wang <wonglam@amazon.com> * Rename workspace_form to workspace_creator_form Signed-off-by: Lin Wang <wonglam@amazon.com> * Clarify workspace form types Signed-off-by: Lin Wang <wonglam@amazon.com> * Add right sidebar to workspace creator Signed-off-by: Lin Wang <wonglam@amazon.com> * Add submitting lock for workspace create page Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #7750 created/updated * Fix form submitting lock not been covered Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 76d7a8b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Move workspace form inside workspace creator * Remove enter details panel * Rename workspace_form to workspace_creator_form * Clarify workspace form types * Add right sidebar to workspace creator * Add submitting lock for workspace create page * Changeset file for PR #7750 created/updated * Fix form submitting lock not been covered --------- (cherry picked from commit 76d7a8b) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for adding workspace right sidebar to workspace create form. Mainly includes below changes:
workspace_forminsideworkspace_creatorfolderIssues Resolved
#7765
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignoreconfig/opensearch_dashboards.ymlyarn start --no-base-pathChangelog
Check List
yarn test:jestyarn test:jest_integration