[Workspace] Content menu picker in side bar and enable searching by Qxisylolo · Pull Request #7881 · opensearch-project/OpenSearch-Dashboards

Qxisylolo · 2024-08-28T08:09:59Z

Description

In this pr, I update content menu picker in side bar and enable searching.

the search bar is sticky, and the workspace is scrollable
enable searching by workspace name.

Screenshot

In a workspace

enable searching

empty state

in the side bar

Changelog

feat: refactor content menu picker in side bar and enable searching

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-08-28T08:25:53Z

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (84d5de3) to head (3009390).
Report is 90 commits behind head on main.

Files with missing lines	Patch %	Lines
...ublic/components/workspace_menu/workspace_menu.tsx	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7881   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files        3728     3728           
  Lines       88297    88309   +12     
  Branches    13662    13666    +4     
=======================================
+ Hits        53439    53453   +14     
+ Misses      31603    31602    -1     
+ Partials     3255     3254    -1

Flag	Coverage Δ
Linux_1	`28.73% <96.55%> (+0.01%)`	⬆️
Linux_2	`56.24% <ø> (ø)`
Linux_3	`37.41% <ø> (+<0.01%)`	⬆️
Linux_4	`29.60% <ø> (ø)`
Windows_1	`28.75% <96.55%> (+0.01%)`	⬆️
Windows_2	`56.20% <ø> (ø)`
Windows_3	`37.41% <ø> (ø)`
Windows_4	`29.60% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

SuZhou-Joe · 2024-09-05T06:52:27Z

Thanks for the PR, good job!

SuZhou-Joe · 2024-09-05T09:57:24Z

Run cypress tests (osd:ciGroup6) should be irrelevant to the code changes.

* 01-feat/refractor-content-menu-picker-in-side-bar Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 02-enable-associated-icon Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 03-update-side-bar Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 04-fix-bugs Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 04-fix-bugs, add test Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 05-delete search Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 06-delete search Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 06-fix-bug Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 07-fix-conflication-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 07-fix-conflication-adjust-icon-size Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR #7881 created/updated --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit a05c4a2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…) (#8017) * 01-feat/refractor-content-menu-picker-in-side-bar * 02-enable-associated-icon * 03-update-side-bar * 04-fix-bugs * 04-fix-bugs, add test * 05-delete search * 06-delete search * 06-fix-bug * 07-fix-conflication-1 * 07-fix-conflication-adjust-icon-size * Changeset file for PR #7881 created/updated --------- (cherry picked from commit a05c4a2) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…) (#8017) * 01-feat/refractor-content-menu-picker-in-side-bar * 02-enable-associated-icon * 03-update-side-bar * 04-fix-bugs * 04-fix-bugs, add test * 05-delete search * 06-delete search * 06-fix-bug * 07-fix-conflication-1 * 07-fix-conflication-adjust-icon-size * Changeset file for PR #7881 created/updated --------- (cherry picked from commit a05c4a2) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit f29bc57) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…) (#8017) (#8049) * 01-feat/refractor-content-menu-picker-in-side-bar * 02-enable-associated-icon * 03-update-side-bar * 04-fix-bugs * 04-fix-bugs, add test * 05-delete search * 06-delete search * 06-fix-bug * 07-fix-conflication-1 * 07-fix-conflication-adjust-icon-size * Changeset file for PR #7881 created/updated --------- (cherry picked from commit a05c4a2) (cherry picked from commit f29bc57) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the repeat-contributor label Aug 28, 2024

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 28, 2024

Changeset file for PR opensearch-project#7881 created/updated

8f33838

raintygao reviewed Aug 28, 2024

View reviewed changes

Comment thread src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx Outdated

Comment thread src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx Outdated

Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 8f33838 to 0afaea9 Compare August 28, 2024 10:52

Qxisylolo changed the title ~~[Workspace] refractor content menu picker in side bar and enable searching~~ [Workspace] Style content menu picker in side bar and enable searching Aug 29, 2024

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 29, 2024

Changeset file for PR opensearch-project#7881 created/updated

8200975

Qxisylolo changed the title ~~[Workspace] Style content menu picker in side bar and enable searching~~ [Workspace] Content menu picker in side bar and enable searching Aug 29, 2024

Qxisylolo marked this pull request as ready for review August 29, 2024 01:41

Qxisylolo requested review from AMoo-Miki, BionIT, Flyingliuhub, LDrago27, SuZhou-Joe, ZilongX, abbyhu2000, ananzh, ashwin-pc, bandinib-amzn, curq, joshuarrrr, kavilla, manasvinibs, mengweieric, ruanyl, xinruiba, zengyan-amazon, zhongnansu and zhyuanqi as code owners August 29, 2024 01:41

Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 50492da to 407184f Compare September 2, 2024 03:38

SuZhou-Joe reviewed Sep 2, 2024

View reviewed changes

Comment thread src/plugins/workspace/public/components/workspace_picker_content/workspace_picker_content.tsx Outdated

Qxisylolo added 8 commits September 3, 2024 14:43

01-feat/refractor-content-menu-picker-in-side-bar

1f36b87

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

02-enable-associated-icon

00c0bfa

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

03-update-side-bar

89e0e00

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

04-fix-bugs

2a78511

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

04-fix-bugs, add test

c9e22ea

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

05-delete search

044f267

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

06-delete search

fc8108e

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

06-fix-bug

dd47fb0

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 811f37b to dd47fb0 Compare September 3, 2024 06:43

SuZhou-Joe previously approved these changes Sep 3, 2024

View reviewed changes

07-fix-conflication

ac4d75f

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Qxisylolo dismissed SuZhou-Joe’s stale review via ac4d75f September 5, 2024 05:44

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Sep 5, 2024

Changeset file for PR opensearch-project#7881 created/updated

41a4ef9

07-fix-conflication-1

a77a6b5

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 41a4ef9 to a77a6b5 Compare September 5, 2024 05:55

Qxisylolo and others added 2 commits September 5, 2024 14:03

07-fix-conflication-adjust-icon-size

58ca05f

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

Changeset file for PR opensearch-project#7881 created/updated

3009390

SuZhou-Joe approved these changes Sep 5, 2024

View reviewed changes

ruanyl approved these changes Sep 5, 2024

View reviewed changes

SuZhou-Joe merged commit a05c4a2 into opensearch-project:main Sep 5, 2024

opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024

[Backport 2.x] [Workspace] Content menu picker in side bar and enable searching #8017

Merged

AMoo-Miki added the in-next label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Content menu picker in side bar and enable searching#7881

[Workspace] Content menu picker in side bar and enable searching#7881
SuZhou-Joe merged 12 commits intoopensearch-project:mainfrom
Qxisylolo:feat/refractor-content-menu-picker-in-side-bar

Qxisylolo commented Aug 28, 2024 •

edited

Loading

Uh oh!

codecov bot commented Aug 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SuZhou-Joe commented Sep 5, 2024

Uh oh!

SuZhou-Joe commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Qxisylolo commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshot

Changelog

Check List

Uh oh!

codecov bot commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SuZhou-Joe commented Sep 5, 2024

Uh oh!

SuZhou-Joe commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Qxisylolo commented Aug 28, 2024 •

edited

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading