[discover] S3 data connection#7917
Conversation
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7917 +/- ##
==========================================
- Coverage 64.30% 64.30% -0.01%
==========================================
Files 3673 3674 +1
Lines 81126 81134 +8
Branches 12928 12926 -2
==========================================
+ Hits 52171 52172 +1
- Misses 25744 25751 +7
Partials 3211 3211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| timer(0, 5000) | ||
| .pipe( | ||
| mergeMap(() => | ||
| http.fetch('../../api/enhancements/datasource/jobs', { |
There was a problem hiding this comment.
is the ../.. needed? and should this be http.get since it's more explicit?
| filter((response) => response.status === 'SUCCESS'), | ||
| map((response) => { | ||
| if (response.status === 'FAILED') { | ||
| throw new Error('Job failed'); |
There was a problem hiding this comment.
failed response shouldn't get here after the filter?
There was a problem hiding this comment.
you are right will clean this up post merge.
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7917-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f4cbbb30964ae8fc63137ca443c2b122def9681
# Push it to GitHub
git push --set-upstream origin backport/backport-7917-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
Update the S3 type config.
This commit does:
Browsing connections, databases, tables
Creating a dataset from a table and setting the string correctly.
This commit does NOT:
Cache data structures
Use session ID for querying
Re-add async polling to search interceptor
---------
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1f4cbbb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7917-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f4cbbb30964ae8fc63137ca443c2b122def9681
# Push it to GitHub
git push --set-upstream origin backport/backport-7917-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
Update the S3 type config.
This commit does:
Browsing connections, databases, tables
Creating a dataset from a table and setting the string correctly.
This commit does NOT:
Cache data structures
Use session ID for querying
Re-add async polling to search interceptor
---------
(cherry picked from commit 1f4cbbb)
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Update the S3 type config.
This PR contains:
This PR does NOT:
Issues Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration