[Workspace] Hide delete button for non OSD admin#7987
Merged
SuZhou-Joe merged 5 commits intoopensearch-project:mainfrom Sep 5, 2024
Merged
[Workspace] Hide delete button for non OSD admin#7987SuZhou-Joe merged 5 commits intoopensearch-project:mainfrom
SuZhou-Joe merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…OpenSearch-Dashboards into workspace_hide_delete_button
Kapian1234
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
ruanyl
approved these changes
Sep 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7987 +/- ##
==========================================
+ Coverage 61.09% 61.10% +0.01%
==========================================
Files 3691 3691
Lines 87310 87312 +2
Branches 13433 13434 +1
==========================================
+ Hits 53340 53356 +16
+ Misses 30722 30709 -13
+ Partials 3248 3247 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
approved these changes
Sep 4, 2024
SuZhou-Joe
approved these changes
Sep 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Hide workspace delete button for non OSD admin Signed-off-by: Kapian1234 <wanjinch@amazon.com> * hide delete action instead of disabled Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #7987 created/updated --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 84d5de3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Hide workspace delete button for non OSD admin * hide delete action instead of disabled * Changeset file for PR #7987 created/updated --------- (cherry picked from commit 84d5de3) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Hide workspace delete button for non OSD admin * hide delete action instead of disabled * Changeset file for PR #7987 created/updated --------- (cherry picked from commit 84d5de3) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit a49876b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Hide workspace delete button for non OSD admin * hide delete action instead of disabled * Changeset file for PR #7987 created/updated --------- (cherry picked from commit 84d5de3) (cherry picked from commit a49876b) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hide delete button for non OSD admin in workspace list page and detail page.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration