[Workspace] Hide first home breadcrumbs within workspace by Hailong-am · Pull Request #7992 · opensearch-project/OpenSearch-Dashboards

Hailong-am · 2024-09-04T16:42:15Z

Description

Hide the home breadcrumbs when we are in a workspace, but keep it in recent popover

Issues Resolved

Screenshot

Testing the changes

Changelog

feat: [Workspace] Hide home breadcrumbs when in a workspace

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Hailong-am · 2024-09-04T16:46:08Z

@AMoo-Miki @zhongnansu can you help to review this change?

codecov · 2024-09-04T23:47:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.52%. Comparing base (84d5de3) to head (7968674).
Report is 90 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7992   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files        3728     3728           
  Lines       88297    88300    +3     
  Branches    13662    13663    +1     
=======================================
+ Hits        53439    53444    +5     
+ Misses      31603    31602    -1     
+ Partials     3255     3254    -1

Flag	Coverage Δ
Linux_1	`28.72% <20.00%> (-0.01%)`	⬇️
Linux_2	`56.25% <100.00%> (+<0.01%)`	⬆️
Linux_3	`37.41% <0.00%> (+<0.01%)`	⬆️
Linux_4	`29.60% <0.00%> (-0.01%)`	⬇️
Windows_1	`28.73% <20.00%> (-0.01%)`	⬇️
Windows_2	`56.20% <100.00%> (+<0.01%)`	⬆️
Windows_3	`37.41% <0.00%> (-0.01%)`	⬇️
Windows_4	`29.60% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>

ruanyl · 2024-09-05T03:38:48Z

    crumbs = breadcrumbEnricher(crumbs);
  }

+  if (dropHomeFromBreadcrumb && crumbs.length && Object.hasOwn(crumbs[0], 'home')) {


Do we need to check if home is true?

we could add this condition as well. There only have one place to set this additional property, i think it's ok only check existence.

Can we have the assumption that when home is set, it must be true?

Yes, i think so. home is not a defined property on ChromeBreadcrumb, ideally nobody else will set this property

zhongnansu

lgtm

SuZhou-Joe · 2024-09-05T09:53:13Z

Run cypress tests (osd:ciGroup6) should be irrelevant to the code changes.

* hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ce (#8015) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix 2.x issue (#8021) Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>

…ce (#8015) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7992 created/updated * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> * don't relay on text to drop home Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 63d0d32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix 2.x issue (#8021) Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit ee2656b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ce (#8015) (#8050) * [Workspace] Hide first home breadcrumbs within workspace (#7992) * hide first home breadcrumbs within workspace * Changeset file for PR #7992 created/updated * don't relay on text to drop home * don't relay on text to drop home --------- (cherry picked from commit 63d0d32) * fix 2.x issue (#8021) --------- (cherry picked from commit ee2656b) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>

github-actions bot added the all-star-contributor label Sep 4, 2024

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 4, 2024

Changeset file for PR opensearch-project#7992 created/updated

f0611c4

Hailong-am marked this pull request as ready for review September 4, 2024 16:46

ruanyl added backport 2.x v2.17.0 labels Sep 5, 2024

Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 5, 2024

Changeset file for PR opensearch-project#7992 created/updated

7e747eb

Hailong-am force-pushed the hide_home_breadcrumbs_for_workspace branch from d48a366 to d2d7262 Compare September 5, 2024 03:17

Hailong-am and others added 3 commits September 5, 2024 11:21

hide first home breadcrumbs within workspace

e1c3dff

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Changeset file for PR opensearch-project#7992 created/updated

cd0a375

don't relay on text to drop home

b83d54f

Signed-off-by: Hailong Cui <ihailong@amazon.com>

SuZhou-Joe force-pushed the hide_home_breadcrumbs_for_workspace branch from d2d7262 to b83d54f Compare September 5, 2024 03:21

don't relay on text to drop home

7968674

Signed-off-by: Hailong Cui <ihailong@amazon.com>

ruanyl reviewed Sep 5, 2024

View reviewed changes

zhongnansu approved these changes Sep 5, 2024

View reviewed changes

SuZhou-Joe approved these changes Sep 5, 2024

View reviewed changes

SuZhou-Joe added the workspace label Sep 5, 2024

ruanyl approved these changes Sep 5, 2024

View reviewed changes

SuZhou-Joe merged commit 63d0d32 into opensearch-project:main Sep 5, 2024

opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024

[Backport 2.x] [Workspace] Hide first home breadcrumbs within workspace #8015

Merged

AMoo-Miki added the in-next label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Hide first home breadcrumbs within workspace#7992

[Workspace] Hide first home breadcrumbs within workspace#7992
SuZhou-Joe merged 4 commits intoopensearch-project:mainfrom
Hailong-am:hide_home_breadcrumbs_for_workspace

Hailong-am commented Sep 4, 2024

Uh oh!

Hailong-am commented Sep 4, 2024

Uh oh!

codecov bot commented Sep 4, 2024 •

edited

Loading

Uh oh!

ruanyl Sep 5, 2024 •

edited

Loading

Uh oh!

Hailong-am Sep 5, 2024

Uh oh!

ruanyl Sep 5, 2024

Uh oh!

Hailong-am Sep 5, 2024 •

edited

Loading

Uh oh!

zhongnansu left a comment

Uh oh!

SuZhou-Joe commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Hailong-am commented Sep 4, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

Uh oh!

Hailong-am commented Sep 4, 2024

Uh oh!

codecov bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ruanyl Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hailong-am Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

ruanyl Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

Hailong-am Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhongnansu left a comment

Choose a reason for hiding this comment

Uh oh!

SuZhou-Joe commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Sep 4, 2024 •

edited

Loading

ruanyl Sep 5, 2024 •

edited

Loading

Hailong-am Sep 5, 2024 •

edited

Loading