Skip to content

[Bug][Workspace]Fix page display errors and add loading status#8086

Merged
SuZhou-Joe merged 4 commits intoopensearch-project:mainfrom
yubonluo:2.17/add-loading-state
Sep 10, 2024
Merged

[Bug][Workspace]Fix page display errors and add loading status#8086
SuZhou-Joe merged 4 commits intoopensearch-project:mainfrom
yubonluo:2.17/add-loading-state

Conversation

@yubonluo
Copy link
Copy Markdown
Collaborator

@yubonluo yubonluo commented Sep 9, 2024

Description

Fix page display errors:

  • DQC table in workspace detail page
image
  • Add collaborator button in workspace detail page
image

Add loading status when user update workspace.

Issues Resolved

Screenshot

Fix table error:
image

Fix button error:
image

After updating workspace, it will show the loading state.
image

Testing the changes

Changelog

  • fix: [Workspace]Fix page display errors and add loading status

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
Fix page display errors and add loading status
2ab82d6 
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
SuZhou-Joe previously approved these changes Sep 9, 2024
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.59%. Comparing base (ee5d482) to head (777cb85).
Report is 71 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8086   +/-   ##
=======================================
  Coverage   60.58%   60.59%           
=======================================
  Files        3738     3738           
  Lines       88670    88678    +8     
  Branches    13782    13787    +5     
=======================================
+ Hits        53725    53730    +5     
- Misses      31661    31663    +2     
- Partials     3284     3285    +1
Flag Coverage Δ
Linux_1 28.75% <ø> (-0.01%) ⬇️
Linux_2 56.28% <ø> (+0.01%) ⬆️
Linux_3 37.51% <ø> (-0.01%) ⬇️
Linux_4 29.60% <ø> (-0.01%) ⬇️
Windows_1 28.77% <ø> (-0.01%) ⬇️
Windows_2 56.23% <ø> (+0.01%) ⬆️
Windows_3 37.51% <ø> (-0.01%) ⬇️
Windows_4 29.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl reviewed Sep 9, 2024
View reviewed changes
Comment thread src/plugins/workspace/public/components/workspace_form/workspace_permission_setting_panel.tsx Outdated
Comment thread src/plugins/workspace/public/components/workspace_detail_app.tsx Outdated
@yubonluo
optimize the code
e071cd9 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
Merge branch '2.17/add-loading-state' of github.com:yubonluo/OpenSear…
777cb85 
…ch-Dashboards into 2.17/add-loading-state
@SuZhou-Joe SuZhou-Joe merged commit af2b2d4 into opensearch-project:main Sep 10, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
@github-actions @opensearch-changeset-bot
[Bug][Workspace]Fix page display errors and add loading status (#8086)
6f14d5d 
* Fix page display errors and add loading status

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #8086 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit af2b2d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 10, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
@github-actions @opensearch-changeset-bot
[Bug][Workspace]Fix page display errors and add loading status (#8086)
1f3f3e1 
* Fix page display errors and add loading status

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #8086 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit af2b2d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 10, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Sep 11, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Bug][Workspace]Fix page display errors and add loading status (#8086) (
e543f3f 
#8105)

* Fix page display errors and add loading status



* Changeset file for PR #8086 created/updated

* optimize the code



---------



(cherry picked from commit af2b2d4)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 11, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Bug][Workspace]Fix page display errors and add loading status (#8086) (
8fc3fbf 
#8106)

* Fix page display errors and add loading status



* Changeset file for PR #8086 created/updated

* optimize the code



---------



(cherry picked from commit af2b2d4)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees

No one assigned

Labels

all-star-contributor backport 2.x backport 2.17 in-next v2.17.0 workspace

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yubonluo @ruanyl @SuZhou-Joe @AMoo-Miki
⚡