Fix Discover Embeddable not showing _source when all other column are removed#8167
Merged
abbyhu2000 merged 2 commits intoopensearch-project:mainfrom Sep 12, 2024
Merged
Conversation
…e removed Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
LDrago27
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8167 +/- ##
==========================================
+ Coverage 63.84% 63.89% +0.05%
==========================================
Files 3738 3739 +1
Lines 88723 88762 +39
Branches 13803 13814 +11
==========================================
+ Hits 56646 56718 +72
+ Misses 31480 31446 -34
- Partials 597 598 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Sep 12, 2024
abbyhu2000
approved these changes
Sep 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
… removed (#8167) * Fix Discover Embeddable not showing _source when all other columns are removed Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #8167 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9ab4377) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
… removed (#8167) * Fix Discover Embeddable not showing _source when all other columns are removed Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #8167 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9ab4377) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Sep 12, 2024
… removed (#8167) (#8170) * Fix Discover Embeddable not showing _source when all other columns are removed * Changeset file for PR #8167 created/updated --------- (cherry picked from commit 9ab4377) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Sep 12, 2024
… removed (#8167) (#8169) * Fix Discover Embeddable not showing _source when all other columns are removed * Changeset file for PR #8167 created/updated --------- (cherry picked from commit 9ab4377) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Discover Embeddable not showing _source when all other column are removed.
Issues Resolved
Screenshot
Issue Before the fix
BeforeFix.mp4
After Fix
After.Fix.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration