Add loading indicator and counter to query result by abbyhu2000 · Pull Request #8212 · opensearch-project/OpenSearch-Dashboards

abbyhu2000 · 2024-09-17T22:01:50Z

Description

when a query takes longer than 3s to complete, a loading indicator will appear after 3s and will also show a time counter; the completion time will show in seconds.
when a query takes less than 1s to complete, the completion time will be shown in miliseconds.

Issues Resolved

Screenshot

Screen.Recording.2024-09-17.at.2.58.10.PM.mov

Testing the changes

Changelog

feat: Add loading indicator and counter to query result

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-09-17T22:17:43Z

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.06%. Comparing base (cea972f) to head (fec2623).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...query_string/language_service/lib/query_result.tsx	70.00%	6 Missing ⚠️
...ic/application/view_components/utils/use_search.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8212   +/-   ##
=======================================
  Coverage   64.05%   64.06%           
=======================================
  Files        3741     3741           
  Lines       88682    88702   +20     
  Branches    13817    13822    +5     
=======================================
+ Hits        56809    56829   +20     
  Misses      31261    31261           
  Partials      612      612

Flag	Coverage Δ
Linux_1	`30.04% <4.76%> (-0.01%)`	⬇️
Linux_2	`58.85% <ø> (ø)`
Linux_3	`40.36% <66.66%> (+0.02%)`	⬆️
Linux_4	`31.42% <5.00%> (-0.01%)`	⬇️
Windows_1	`30.05% <4.76%> (-0.01%)`	⬇️
Windows_2	`58.80% <ø> (ø)`
Windows_3	`40.36% <66.66%> (+0.02%)`	⬆️
Windows_4	`31.42% <5.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

ashwin-pc

Nice!

ashwin-pc · 2024-09-19T23:32:38Z

+  const getTime = () => {
+    const time = new Date().getTime() - props.queryStatus.startTime!;
+    if (time > BUFFER_TIME) {
+      setElapsedTime(time);


Its rounded down to seconds so that should not be a problem. Take a look at the video attached Miki :)

abbyhu2000 · 2024-09-20T17:18:44Z

Link checker failure not related:

* [404] [http://sites.google.com/site/murmurhash/](http://sites.google.com/site/murmurhash/) | Failed: Network error: Not Found

* add loading indicator and counter to query result Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Changeset file for PR #8212 created/updated * add unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * update snapshot Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 27ba36c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* add loading indicator and counter to query result * Changeset file for PR #8212 created/updated * add unit tests * address comments * update snapshot --------- (cherry picked from commit 27ba36c) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…#8212) * add loading indicator and counter to query result Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Changeset file for PR opensearch-project#8212 created/updated * add unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * update snapshot Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…-project#8212) (opensearch-project#8273)" This reverts commit aa42f67.

abbyhu2000 added the discover for discover reinvent label Sep 17, 2024

github-actions bot added the distinguished-contributor label Sep 17, 2024

opensearch-changeset-bot bot added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 17, 2024

Changeset file for PR opensearch-project#8212 created/updated

b1b6e6e

abbyhu2000 pushed a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 17, 2024

Changeset file for PR opensearch-project#8212 created/updated

2fb3d5a

abbyhu2000 force-pushed the loading_query_result branch from b1b6e6e to 2fb3d5a Compare September 17, 2024 22:03

ashwin-pc added the 2.17.1 label Sep 17, 2024