Expose method to register search strategy routes in query enhancement#8245
Conversation
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8245 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 3743 3743
Lines 88833 88833
Branches 13852 13852
=======================================
+ Hits 56979 56980 +1
+ Misses 31239 31238 -1
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
96b3ccc to
dc34749
Compare
|
We merged #8226. Can you rebase on top of the latest changes in main? |
513b764 to
dc34749
Compare
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
dc34749 to
4b96e3c
Compare
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
…ery enhancement (#8282) * exposed method to register search strategy routes Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Changeset file for PR #8245 created/updated * addressed comment Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fix linter error Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8245-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f6924a73d0c1ba257e9febfd650bd1f93350401f
# Push it to GitHub
git push --set-upstream origin backport/backport-8245-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8245-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f6924a73d0c1ba257e9febfd650bd1f93350401f
# Push it to GitHub
git push --set-upstream origin backport/backport-8245-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17Then, create a pull request where the |
…opensearch-project#8245) * exposed method to register search strategy routes Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Changeset file for PR opensearch-project#8245 created/updated * addressed comment Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fix linter error Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
If a new search strategy is registered, we need a way to setup its routes for the search interceptor to call. This PR exposes a setup method to be able to define the routes for the provided strategy
Changelog
Check List
yarn test:jestyarn test:jest_integration