Fix running recent query button by abbyhu2000 · Pull Request #8252 · opensearch-project/OpenSearch-Dashboards

abbyhu2000 · 2024-09-19T23:23:03Z

Description

Fix the bug of running recent query jump to another language.

Issues Resolved

Screenshot

Testing the changes

Changelog

fix: Run recent query button work properly

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-09-19T23:49:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.11%. Comparing base (27ba36c) to head (e21530a).
Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
...query_string/language_service/lib/recent_query.tsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8252   +/-   ##
=======================================
  Coverage   64.11%   64.11%           
=======================================
  Files        3744     3744           
  Lines       88862    88864    +2     
  Branches    13852    13852           
=======================================
+ Hits        56975    56978    +3     
+ Misses      31273    31272    -1     
  Partials      614      614

Flag	Coverage Δ
Linux_1	`30.06% <0.00%> (-0.01%)`	⬇️
Linux_2	`58.85% <ø> (ø)`
Linux_3	`40.35% <0.00%> (-0.01%)`	⬇️
Linux_4	`31.56% <0.00%> (?)`
Windows_1	`30.08% <0.00%> (-0.01%)`	⬇️
Windows_2	`58.80% <ø> (ø)`
Windows_3	`40.36% <0.00%> (-0.01%)`	⬇️
Windows_4	`31.56% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kavilla · 2024-09-20T00:30:56Z

          type: 'icon',
          onClick: (item: RecentQueryTableItem) => {
-            onClickRecentQuery(recentQueries[item.id].query, recentQueries[item.id].timeRange);
+            onClickRecentQuery(


to mind explaining this part a little bit? like how this fixes the problem?

without knowing too much about the implementation, for me this basically looks for the query and assumes its the same query which might not be accurate still i think.

i dont think we show this feature for DQL but in the case of DQL the query could actually just be
"" for multiple queries for different index patterns. And this logic to me would find the first query that is "" and assume that is the recent query.

in SQL and PPL we dont limit what they type so technically they could select data_logs

and in SQL it would be SELECT * FROM data_logs
and then they type it SELECT * FROM eccomerce and then select the eccommerce sample data. so then the query editor says SELECT * FROM eccomerce which query is the right query here.

i think the solution here should be assigning a GUID or using the timestamp of execution as the identifier. then the RecentQueryTableItem.id should be just the id of that GUID or timestamp

make sense. i revised it to use uuid

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

kavilla · 2024-09-20T20:42:40Z

 import { EditorInstance } from '../../../ui/query_editor/editors';

 export interface RecentQueryItem {
+  id: number;


Nit: I think it's a string now right ?

Will fix in later PR

* Fix click on recent query switching language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change to use uuid as identifier Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Changeset file for PR #8252 created/updated --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2f36eaf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix click on recent query switching language * change to use uuid as identifier * Changeset file for PR #8252 created/updated --------- (cherry picked from commit 2f36eaf) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* Fix click on recent query switching language Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change to use uuid as identifier Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Changeset file for PR opensearch-project#8252 created/updated --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ensearch-project#8281)" This reverts commit baee58c.

…-project#8280) * Fix click on recent query switching language * change to use uuid as identifier * Changeset file for PR opensearch-project#8252 created/updated --------- (cherry picked from commit 2f36eaf) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the distinguished-contributor label Sep 19, 2024

opensearch-changeset-bot bot added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 19, 2024

Changeset file for PR opensearch-project#8252 created/updated

ca35b38

ashwin-pc previously approved these changes Sep 19, 2024

View reviewed changes

kavilla reviewed Sep 20, 2024

View reviewed changes

abbyhu2000 added 2 commits September 20, 2024 18:39

Fix click on recent query switching language

1a91dba

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

change to use uuid as identifier

b7cabcb

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Changeset file for PR opensearch-project#8252 created/updated

e21530a

abbyhu2000 dismissed ashwin-pc’s stale review via e21530a September 20, 2024 18:39

abbyhu2000 force-pushed the recent_query_bug branch from ca35b38 to e21530a Compare September 20, 2024 18:39

kavilla approved these changes Sep 20, 2024

View reviewed changes

LDrago27 approved these changes Sep 20, 2024

View reviewed changes

abbyhu2000 merged commit 2f36eaf into opensearch-project:main Sep 20, 2024

abbyhu2000 added discover for discover reinvent 2.17.1 backport 2.x backport 2.17 labels Sep 20, 2024

opensearch-trigger-bot bot mentioned this pull request Sep 20, 2024

[Backport 2.x] Fix running recent query button #8280

Merged

opensearch-trigger-bot bot mentioned this pull request Sep 20, 2024

[Backport 2.17] Fix running recent query button #8281

Merged

abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024

Revert "Fix running recent query button (opensearch-project#8252) (op…

dde9f81

…ensearch-project#8281)" This reverts commit baee58c.

ashwin-pc added v2.18.0 discover-next and removed 2.17.1 backport 2.17 labels Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix running recent query button#8252

Fix running recent query button#8252
abbyhu2000 merged 3 commits intoopensearch-project:mainfrom
abbyhu2000:recent_query_bug

abbyhu2000 commented Sep 19, 2024

Uh oh!

codecov bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

kavilla Sep 20, 2024 •

edited

Loading

Uh oh!

abbyhu2000 Sep 20, 2024

Uh oh!

kavilla Sep 20, 2024

Uh oh!

abbyhu2000 Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

abbyhu2000 commented Sep 19, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

Uh oh!

codecov bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kavilla Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abbyhu2000 Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

kavilla Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

abbyhu2000 Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 19, 2024 •

edited

Loading

kavilla Sep 20, 2024 •

edited

Loading