Skip to content

[Workspace]Update details panel UI in workspace create page#8375

Merged
ruanyl merged 4 commits intoopensearch-project:mainfrom
wanglam:refactor-workspace-creation-details-panel
Sep 30, 2024
Merged

[Workspace]Update details panel UI in workspace create page#8375
ruanyl merged 4 commits intoopensearch-project:mainfrom
wanglam:refactor-workspace-creation-details-panel

Conversation

@wanglam
Copy link
Copy Markdown
Collaborator

@wanglam wanglam commented Sep 29, 2024

Description

This PR is for updating details panel UI in workspace create page. Move the color, name and description input in the same panel like screenshot below.

Issues Resolved

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user and go to workspace create page by bottom left menu
  • The workspace details panel should be displayed like screenshot above
  • The name, color and description field should work as expected

Changelog

  • feat: [Workspace]Update details panel UI in workspace create page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (c1a349a) to head (b714df6).
Report is 161 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8375      +/-   ##
==========================================
- Coverage   60.93%   60.93%   -0.01%     
==========================================
  Files        3749     3750       +1     
  Lines       89038    89043       +5     
  Branches    13903    13906       +3     
==========================================
+ Hits        54251    54254       +3     
- Misses      31425    31426       +1     
- Partials     3362     3363       +1     
Flag Coverage Δ
Linux_1 28.86% <100.00%> (+<0.01%) ⬆️
Linux_2 56.35% <ø> (ø)
Linux_3 37.75% <ø> (-0.01%) ⬇️
Linux_4 29.96% <ø> (ø)
Windows_1 28.87% <100.00%> (+<0.01%) ⬆️
Windows_2 56.30% <ø> (ø)
Windows_3 37.76% <ø> (ø)
Windows_4 29.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam requested a review from huyaboo as a code owner September 29, 2024 10:54
return (
<EuiFlexGroup className="workspaceCreateFormContainer">
<EuiFlexItem style={{ maxWidth: 768 }}>
<EuiFlexItem style={{ maxWidth: 848 }}>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we avoid hard coded with?

@ruanyl ruanyl merged commit 71ab7bb into opensearch-project:main Sep 30, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 1, 2024
* Update details panel UI in workspace create page

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8375 created/updated

* Fix details panel title not rendered

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 71ab7bb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Oct 1, 2024
…8416)

* Update details panel UI in workspace create page



* Changeset file for PR #8375 created/updated

* Fix details panel title not rendered



---------



(cherry picked from commit 71ab7bb)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…ch-project#8375) (opensearch-project#8416)

* Update details panel UI in workspace create page



* Changeset file for PR opensearch-project#8375 created/updated

* Fix details panel title not rendered



---------



(cherry picked from commit 71ab7bb)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants