[Workspace]Update details panel UI in workspace create page#8375
Merged
ruanyl merged 4 commits intoopensearch-project:mainfrom Sep 30, 2024
Merged
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8375 +/- ##
==========================================
- Coverage 60.93% 60.93% -0.01%
==========================================
Files 3749 3750 +1
Lines 89038 89043 +5
Branches 13903 13906 +3
==========================================
+ Hits 54251 54254 +3
- Misses 31425 31426 +1
- Partials 3362 3363 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Sep 29, 2024
ruanyl
approved these changes
Sep 30, 2024
| return ( | ||
| <EuiFlexGroup className="workspaceCreateFormContainer"> | ||
| <EuiFlexItem style={{ maxWidth: 768 }}> | ||
| <EuiFlexItem style={{ maxWidth: 848 }}> |
Member
There was a problem hiding this comment.
Nit: can we avoid hard coded with?
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Update details panel UI in workspace create page Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8375 created/updated * Fix details panel title not rendered Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 71ab7bb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 1, 2024
…8416) * Update details panel UI in workspace create page * Changeset file for PR #8375 created/updated * Fix details panel title not rendered --------- (cherry picked from commit 71ab7bb) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…ch-project#8375) (opensearch-project#8416) * Update details panel UI in workspace create page * Changeset file for PR opensearch-project#8375 created/updated * Fix details panel title not rendered --------- (cherry picked from commit 71ab7bb) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for updating details panel UI in workspace create page. Move the color, name and description input in the same panel like screenshot below.
Issues Resolved
Screenshot
Testing the changes
yarn osd bootstrap --single-version looseconfig/opensearch_dashboards.ymlyarn start --no-base-pathChangelog
Check List
yarn test:jestyarn test:jest_integration