[Workspace] Refactor data source association panel#8383
Merged
SuZhou-Joe merged 9 commits intoopensearch-project:mainfrom Sep 30, 2024
Merged
Conversation
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Kapian1234
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
wanglam
reviewed
Sep 30, 2024
| <EuiSpacer size="m" /> | ||
| {/* SelectDataSourcePanel is only visible for dashboard admin and when data source is enabled*/} | ||
| {isDashboardAdmin && isDataSourceEnabled && ( | ||
| <> |
Collaborator
There was a problem hiding this comment.
Can we keep this fragment?
wanglam
reviewed
Sep 30, 2024
| </> | ||
| </EuiPanel> | ||
| )} | ||
| <EuiSpacer size="s" /> |
Collaborator
There was a problem hiding this comment.
I think these spacer should be inside fragment, then it won't take extra spaces when data source not enabled.
Contributor
Author
There was a problem hiding this comment.
Maybe these spacer could be deleted since we have padding in the panel now
Collaborator
There was a problem hiding this comment.
These spacing is between panel and panel right? This spacing should follow data source panel. It should be hidden if data source panel not displayed.
Contributor
Author
There was a problem hiding this comment.
oh, I get it. thank you
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
wanglam
reviewed
Sep 30, 2024
| {i18n.translate('workspace.creator.form.associateDataSourceTitle', { | ||
| defaultMessage: 'Associate data sources', | ||
| <EuiPanel> | ||
| <EuiTitle |
Collaborator
There was a problem hiding this comment.
Can we use EuiText + h2 as panel title like this to align with the guidance.
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
wanglam
reviewed
Sep 30, 2024
| showDataSourceManagement={true} | ||
| /> | ||
| </EuiText> | ||
| <SelectDataSourcePanel |
Collaborator
There was a problem hiding this comment.
Do we need more spacing between description and SelectDataSourcePanel?
Contributor
Author
There was a problem hiding this comment.
In SelectDataSourcePanel, there's already a <EuiSpacer size="m" />, and it would display only when the table exists
ruanyl
previously approved these changes
Sep 30, 2024
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
SuZhou-Joe
reviewed
Sep 30, 2024
wanglam
reviewed
Sep 30, 2024
Collaborator
There was a problem hiding this comment.
@Kapian1234 I think this file should not be included in this PR. Can we remove it?
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
ruanyl
approved these changes
Sep 30, 2024
wanglam
approved these changes
Sep 30, 2024
SuZhou-Joe
approved these changes
Sep 30, 2024
SuZhou-Joe
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
* refactor association panel Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #8383 created/updated * resolve some issues Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update title style Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update title style Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update placeholder Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update placeholder Signed-off-by: Kapian1234 <wanjinch@amazon.com> * / Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 83d5fba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 1, 2024
* refactor association panel * Changeset file for PR #8383 created/updated * resolve some issues * update title style * update title style * update placeholder * update placeholder * / --------- (cherry picked from commit 83d5fba) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…t#8383) (opensearch-project#8419) * refactor association panel * Changeset file for PR opensearch-project#8383 created/updated * resolve some issues * update title style * update title style * update placeholder * update placeholder * / --------- (cherry picked from commit 83d5fba) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor data source association panel
Issues Resolved
Screenshot
before
after
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration