Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin#8394
Conversation
❌ Entry Too LongEntry is 110 characters long, which is 10 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8394 +/- ##
=======================================
Coverage 60.92% 60.92%
=======================================
Files 3750 3752 +2
Lines 89103 89135 +32
Branches 13925 13932 +7
=======================================
+ Hits 54285 54306 +21
- Misses 31442 31451 +9
- Partials 3376 3378 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…entifiers in dataSourceManagement plugin Signed-off-by: Miki <miki@amazon.com>
RyanL1997
left a comment
There was a problem hiding this comment.
@AMoo-Miki Thanks for taking this on. In generally looking good to me. In addition, could @BionIT check some of the Opensearch Connection related change?
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8394-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9da5f9ba13807263c3bcb063d954ad8da2b0716d
# Push it to GitHub
git push --set-upstream origin backport/backport-8394-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8394-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9da5f9ba13807263c3bcb063d954ad8da2b0716d
# Push it to GitHub
git push --set-upstream origin backport/backport-8394-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
…entifiers in dataSourceManagement plugin (opensearch-project#8394) * Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR opensearch-project#8394 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9da5f9b) Signed-off-by: Miki <miki@amazon.com>
…entifiers in dataSourceManagement plugin (#8394) (#8516) * Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin * Changeset file for PR #8394 created/updated --------- (cherry picked from commit 9da5f9b) Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…entifiers in dataSourceManagement plugin (opensearch-project#8394) (opensearch-project#8516) * Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin * Changeset file for PR opensearch-project#8394 created/updated --------- (cherry picked from commit 9da5f9b) Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com>
Description
Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin
Changelog
Check List
yarn test:jestyarn test:jest_integration