Skip to content

Fix unprefixed i18n identifiers in examples#8412

Merged
ashwin-pc merged 4 commits intoopensearch-project:mainfrom
AMoo-Miki:i18n-examples
Oct 3, 2024
Merged

Fix unprefixed i18n identifiers in examples#8412
ashwin-pc merged 4 commits intoopensearch-project:mainfrom
AMoo-Miki:i18n-examples

Conversation

@AMoo-Miki
Copy link
Copy Markdown
Collaborator

@AMoo-Miki AMoo-Miki commented Oct 1, 2024 •
edited
Loading

Description

Fix unprefixed i18n identifiers in examples

Changelog

  • fix: Fix unprefixed i18n identifiers in examples

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Fix unprefixed and duplicate i18n identifiers in examples
af7a3c4 
Signed-off-by: Miki <miki@amazon.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.94%. Comparing base (a663a84) to head (eeb15e2).
⚠️ Report is 1234 commits behind head on main.

Files with missing lines Patch % Lines
...es/public/list_container/list_container_factory.ts 0.00% 1 Missing ⚠️
...amples/public/todo/todo_ref_embeddable_factory.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8412      +/-   ##
==========================================
+ Coverage   60.92%   60.94%   +0.01%     
==========================================
  Files        3750     3757       +7     
  Lines       89103    89265     +162     
  Branches    13925    13959      +34     
==========================================
+ Hits        54285    54400     +115     
- Misses      31442    31478      +36     
- Partials     3376     3387      +11
Flag Coverage Δ
Linux_1 28.87% <ø> (+0.04%) ⬆️
Linux_2 56.35% <ø> (-0.01%) ⬇️
Linux_3 37.78% <ø> (+0.05%) ⬆️
Linux_4 29.96% <0.00%> (-0.01%) ⬇️
Windows_1 28.88% <ø> (+0.04%) ⬆️
Windows_2 56.30% <ø> (-0.01%) ⬇️
Windows_3 37.78% <ø> (+0.05%) ⬆️
Windows_4 29.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ashwin-pc ashwin-pc added the i18n Internationalization related Issues and PRs label Oct 1, 2024
LDrago27
LDrago27 previously approved these changes Oct 1, 2024
View reviewed changes
ashwin-pc
ashwin-pc reviewed Oct 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing the keys?

@AMoo-Miki
Copy link
Copy Markdown
Collaborator Author

AMoo-Miki commented Oct 3, 2024

Why are we changing the keys?

Either they are a duplicate of another key with a different value, or they are not using the namespace for this folder.

@ashwin-pc
Copy link
Copy Markdown
Member

ashwin-pc commented Oct 3, 2024

Lets make sure to add those to the linter rules. I can see this easily drift in future :)

@ashwin-pc ashwin-pc merged commit 2f541ff into opensearch-project:main Oct 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
@github-actions @opensearch-changeset-bot
Fix unprefixed i18n identifiers in examples (#8412)
be0ab4d 
* Fix unprefixed and duplicate i18n identifiers in examples

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8412 created/updated

* Changeset file for PR #8412 created/updated

* Changeset file for PR #8412 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2f541ff)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 3, 2024
Merged
ruanyl pushed a commit that referenced this pull request Oct 4, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Fix unprefixed i18n identifiers in examples (#8412) (#8477)
3fb549d 
* Fix unprefixed and duplicate i18n identifiers in examples



* Changeset file for PR #8412 created/updated

* Changeset file for PR #8412 created/updated

* Changeset file for PR #8412 created/updated

---------



(cherry picked from commit 2f541ff)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ruchidh pushed a commit to ruchidh/OpenSearch-Dashboards that referenced this pull request Jul 18, 2025
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @ruchidh
Fix unprefixed i18n identifiers in examples (opensearch-project#8412) (…
bcc7a97 
…opensearch-project#8477)

* Fix unprefixed and duplicate i18n identifiers in examples

* Changeset file for PR opensearch-project#8412 created/updated

* Changeset file for PR opensearch-project#8412 created/updated

* Changeset file for PR opensearch-project#8412 created/updated

---------

(cherry picked from commit 2f541ff)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Ruchi Sharma <ruchi492@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@LDrago27 LDrago27 LDrago27 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees

@ashwin-pc ashwin-pc

Labels

backport 2.x distinguished-contributor i18n Internationalization related Issues and PRs v2.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AMoo-Miki @ashwin-pc @LDrago27
⚡