[Workspace]Fix use case hidden features not accessible#8445
Merged
Hailong-am merged 6 commits intoopensearch-project:mainfrom Oct 3, 2024
Merged
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8445 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3758 3758
Lines 89288 89305 +17
Branches 13970 13972 +2
=======================================
+ Hits 54422 54437 +15
- Misses 31478 31479 +1
- Partials 3388 3389 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
reviewed
Oct 2, 2024
…ce_use_case_flyout.tsx Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
approved these changes
Oct 3, 2024
Hailong-am
approved these changes
Oct 3, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8445-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 638f753241dc0eccb089e3225e7a574ee41355a0
# Push it to GitHub
git push --set-upstream origin backport/backport-8445-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
Collaborator
|
backport depends on #8444 to be merged first |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Fix use case hidden features not accessible Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8445 created/updated * Change to useCaseWithDisplayedFeatures Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove not used import Signed-off-by: Lin Wang <wonglam@amazon.com> * Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 638f753) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Fix use case hidden features not accessible * Changeset file for PR #8445 created/updated * Change to useCaseWithDisplayedFeatures * Remove not used import * Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx --------- (cherry picked from commit 638f753) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…oject#8445) (opensearch-project#8459) * Fix use case hidden features not accessible * Changeset file for PR opensearch-project#8445 created/updated * Change to useCaseWithDisplayedFeatures * Remove not used import * Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx --------- (cherry picked from commit 638f753) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for fixing hidden features not accessible due to #8413 . The use case selector refactor PR modified the features array and removed features not displayed in the flyout. These features should be accessed even they not displayed in the use case flyout (such as: getting started, overview, all custom features).
Screenshot
No UI Changes.
Testing the changes
yarn osd bootstrap --single-version looseconfig/opensearch_dashboards.ymlyarn start --no-base-pathChangelog
Check List
yarn test:jestyarn test:jest_integration