[Workspace]Restrict at least one data source in workspace creation page#8461
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8461 +/- ##
==========================================
- Coverage 60.95% 60.95% -0.01%
==========================================
Files 3758 3758
Lines 89326 89331 +5
Branches 13974 13977 +3
==========================================
+ Hits 54453 54456 +3
- Misses 31481 31482 +1
- Partials 3392 3393 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ace-create Signed-off-by: Lin Wang <wonglam@amazon.com>
…ge (#8461) * Restrict at least one data sources for workspace creation Signed-off-by: Lin Wang <wonglam@amazon.com> * Update empty data sources panel UI Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8461 created/updated * Fix wrong testing id for data source empty state Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove populate workspace name Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ec4b9d7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ge (#8461) (#8468) * Restrict at least one data sources for workspace creation * Update empty data sources panel UI * Changeset file for PR #8461 created/updated * Fix wrong testing id for data source empty state * Remove populate workspace name --------- (cherry picked from commit ec4b9d7) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ge (opensearch-project#8461) (opensearch-project#8468) * Restrict at least one data sources for workspace creation * Update empty data sources panel UI * Changeset file for PR opensearch-project#8461 created/updated * Fix wrong testing id for data source empty state * Remove populate workspace name --------- (cherry picked from commit ec4b9d7) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com>
Description
This PR is for adding required restriction for data source selector in workspace creation page. The create workspace button will be disabled if no data sources assigned. It added a empty prompt message for indicate this behavior when no data source assigned. This PR also removed the populated workspace name.
Screenshot
Testing the changes
yarn osd bootstrap --single-version looseconfig/opensearch_dashboards.ymlyarn start --no-base-pathChangelog
Check List
yarn test:jestyarn test:jest_integration