[Workspace] add data-connection type support for association modal#8620
Merged
SuZhou-Joe merged 4 commits intoopensearch-project:mainfrom Oct 18, 2024
Merged
[Workspace] add data-connection type support for association modal#8620SuZhou-Joe merged 4 commits intoopensearch-project:mainfrom
SuZhou-Joe merged 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8620 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3792 3792
Lines 90355 90359 +4
Branches 14170 14170
=======================================
+ Hits 55072 55077 +5
+ Misses 31822 31821 -1
Partials 3461 3461
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
approved these changes
Oct 18, 2024
SuZhou-Joe
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
…8620) * add DQS type support for association modal Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #8620 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 32b11de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 18, 2024
…8620) (#8646) * add DQS type support for association modal * Changeset file for PR #8620 created/updated --------- (cherry picked from commit 32b11de) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Oct 19, 2024
…pensearch-project#8620) * add DQS type support for association modal Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#8620 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…pensearch-project#8620) * add DQS type support for association modal Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#8620 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…pensearch-project#8620) * add DQS type support for association modal Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#8620 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ruchidh
pushed a commit
to ruchidh/OpenSearch-Dashboards
that referenced
this pull request
Jul 18, 2025
…pensearch-project#8620) (opensearch-project#8646) * add DQS type support for association modal * Changeset file for PR opensearch-project#8620 created/updated --------- (cherry picked from commit 32b11de) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add data-connection type support for association modal
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration