Add support for async ppl to discover#8706
Conversation
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8706 +/- ##
=======================================
Coverage 60.74% 60.75%
=======================================
Files 3798 3798
Lines 90685 90685
Branches 14272 14272
=======================================
+ Hits 55091 55093 +2
- Misses 32095 32139 +44
+ Partials 3499 3453 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
kavilla
left a comment
There was a problem hiding this comment.
lgtm me! awesome! idk why the ci failed like twice specifically for this pr but i dont see any reason for this pr so it might be due to github.
sejli
left a comment
There was a problem hiding this comment.
Looks good to me!
One question I have is regarding aggregations support: Should async PPL support timefields/histogram? The ppl_async_search_strategy mimics the sql_async_search_strategy, which doesn't have histogram support.
Yes this is what we want as a fast follow, this PR doesn't have workflows where a time field is selected. This is a pre-req for histogram support. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8706-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e1a1b8f103701666c271252d4bf569e595f5969a
# Push it to GitHub
git push --set-upstream origin backport/backport-8706-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
…ch-project#8706) Backport PR: opensearch-project#8706 From original PR: * add support for async ppl to discover Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Changeset file for PR opensearch-project#8706 created/updated * update s3_type test to add PPL as supported lang Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix lint error Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…8769) Backport PR: #8706 From original PR: * add support for async ppl to discover * Changeset file for PR #8706 created/updated * update s3_type test to add PPL as supported lang * fix lint error --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* add support for async ppl to discover Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Changeset file for PR opensearch-project#8706 created/updated * update s3_type test to add PPL as supported lang Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix lint error Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ch-project#8706) (opensearch-project#8769) Backport PR: opensearch-project#8706 From original PR: * add support for async ppl to discover * Changeset file for PR opensearch-project#8706 created/updated * update s3_type test to add PPL as supported lang * fix lint error --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com>
Description
Add support for async ppl to discover
Issues Resolved
source = ${dataset.title} | head 10Screenshot
discover-ppl-flint.mov
Changelog
Check List
yarn test:jestyarn test:jest_integration