[Workspace] [Bug] Fix index pattern issue#8718
Merged
Hailong-am merged 1 commit intoopensearch-project:mainfrom Oct 29, 2024
Merged
[Workspace] [Bug] Fix index pattern issue#8718Hailong-am merged 1 commit intoopensearch-project:mainfrom
Hailong-am merged 1 commit intoopensearch-project:mainfrom
Conversation
opensearch-changeset-bot bot
added a commit
to yubonluo/OpenSearch-Dashboards
that referenced
this pull request
Oct 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8718 +/- ##
==========================================
- Coverage 60.74% 60.74% -0.01%
==========================================
Files 3798 3798
Lines 90660 90662 +2
Branches 14259 14259
==========================================
Hits 55072 55072
- Misses 32092 32093 +1
- Partials 3496 3497 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
previously approved these changes
Oct 28, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
a42c381 to
ea66730
Compare
Member
|
Does this need a backport? |
Collaborator
Author
Yes, this pr needs to be backported into 2.x. |
ruanyl
approved these changes
Oct 29, 2024
Hailong-am
approved these changes
Oct 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com> (cherry picked from commit 815f466) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com> (cherry picked from commit 815f466) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Oct 29, 2024
Hailong-am
pushed a commit
that referenced
this pull request
Oct 29, 2024
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
7 tasks
ruchidh
pushed a commit
to ruchidh/OpenSearch-Dashboards
that referenced
this pull request
Jul 18, 2025
…#8734) (cherry picked from commit 815f466) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix index pattern issue:
When workspace is enabled, there should not be a global default index pattern setting, the "Set as default" button should not be displayed in "Global assets" → "inspect" page.
The current workspace default index pattern setting extends the global value, but this is not expected, we should fix this by not extending from global setting for workspace default index pattern. If non-workspace-admin user has no the permission of the global index pattern and the default index pattern of workspace level, they can not load the dashboard

Inspect button should go to the link inside a workspace.
Issues Resolved
N/A
Screenshot
4a3131c0-94ee-11ef-a923-9f39d35cdf7c_b4c0b625-ee20-4afd-aa13-da0866f0b117There is no default index pattern in the current workspace and current user have no the permission of the global index pattern, the dashboard page should load normally
2024-10-28.18.16.00.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration