[Discover] fix error handling in query enhancement facet

[joshuali925]

Description

In query enhancements facet, the fetch errors are caught and returned as

{ success: false, data: Error }

OpenSearch-Dashboards/src/plugins/query_enhancements/server/utils/facet.ts

Lines 90 to 96 in c66b698

	} catch (err: any) {
	this.logger.error(`Facet fetch: ${endpoint}: ${err}`);
	return {
	success: false,
	data: err,
	};
	}

OpenSearch-Dashboards/src/plugins/query_enhancements/server/utils/facet.ts

Lines 64 to 70 in c66b698

	} catch (err: any) {
	this.logger.error(`Facet fetch: ${endpoint}: ${err}`);
	return {
	success: false,
	data: err,
	};
	}

But describeQuery is not checking if success is true, and will process the Error object as IPPLEventsDataSource or IPPLVisualizationDataSource, causing internal server error.

OpenSearch-Dashboards/src/plugins/query_enhancements/server/utils/facet.ts

Lines 107 to 108 in c66b698

	jdbc: (data: any) => shimSchemaRow(data as IPPLEventsDataSource),
	viz: (data: any) => shimStats(data as IPPLVisualizationDataSource),

@kavilla @mengweieric @ps48 let me know if this is not a good fix

Issues Resolved

Screenshot

Testing the changes

Changelog

• fix: fix error handling in query enhancement facet

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.75%. Comparing base (c66b698) to head (6dd9ad6).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/plugins/query_enhancements/common/utils.ts	0.00%	2 Missing ⚠️
...c/plugins/query_enhancements/server/utils/facet.ts	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8743   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files        3798     3798           
  Lines       90682    90683    +1     
  Branches    14271    14271           
=======================================
+ Hits        55092    55094    +2     
+ Misses      32093    32092    -1     
  Partials     3497     3497           

Flag	Coverage Δ
Linux_1	29.06% <ø> (ø)
Linux_2	56.39% <ø> (ø)
Linux_3	37.60% <ø> (ø)
Linux_4	29.83% <0.00%> (+<0.01%)	⬆️
Windows_1	29.07% <ø> (ø)
Windows_2	56.34% <ø> (ø)
Windows_3	37.60% <ø> (ø)
Windows_4	29.82% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.