[Discover] Prevent wrapping of time fields#8755
Merged
AMoo-Miki merged 2 commits intoopensearch-project:mainfrom Oct 30, 2024
Merged
[Discover] Prevent wrapping of time fields#8755AMoo-Miki merged 2 commits intoopensearch-project:mainfrom
AMoo-Miki merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Contributor
❌ Entry Too LongEntry is 103 characters long, which is 3 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
ashwin-pc
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8755 +/- ##
=======================================
Coverage 60.75% 60.75%
=======================================
Files 3798 3798
Lines 90685 90685
Branches 14272 14272
=======================================
Hits 55093 55093
Misses 32094 32094
Partials 3498 3498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ananzh
approved these changes
Oct 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Prevent wrapping of time fields Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8755 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 056e481) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Prevent wrapping of time fields Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8755 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 056e481) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Prevent wrapping of time fields * Changeset file for PR #8755 created/updated --------- (cherry picked from commit 056e481) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Nov 1, 2024
* Prevent wrapping of time fields Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR opensearch-project#8755 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ruchidh
pushed a commit
to ruchidh/OpenSearch-Dashboards
that referenced
this pull request
Jul 18, 2025
…pensearch-project#8756) * Prevent wrapping of time fields * Changeset file for PR opensearch-project#8755 created/updated --------- (cherry picked from commit 056e481) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent wrapping of time fields which causes an overlap when languages are changed in the query editor.
Note: Discover still needs to allow triggering a re-render for a better solution.
Before
Screen.Recording.2024-10-30.at.11.29.36.AM.mp4
After
Screen.Recording.2024-10-30.at.11.30.02.AM.mp4
Changelog
Check List
yarn test:jestyarn test:jest_integration