Skip to content

Add tooltip and disabled to panel item#9696

Merged
Hailong-am merged 13 commits intoopensearch-project:mainfrom
yyfamazon:addActionId
Apr 29, 2025
Merged

Add tooltip and disabled to panel item#9696
Hailong-am merged 13 commits intoopensearch-project:mainfrom
yyfamazon:addActionId

Conversation

@yyfamazon
Copy link
Copy Markdown
Contributor

@yyfamazon yyfamazon commented Apr 21, 2025 •
edited by ruanyl
Loading

Description

Add tooltip and disabled to context. So the generate visualization button can be disabled when there is no results or there is error: https://github.com/opensearch-project/dashboards-assistant/pull/546/files

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: ui action supports isDisabled and getTooltip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yyfamazon
add action id
4a95a98 
Signed-off-by: yyfamazon <yyf@amazon.com>
@yyfamazon
fix test
513a3ef 
Signed-off-by: yyfamazon <yyf@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

ruanyl
ruanyl reviewed Apr 25, 2025
View reviewed changes
Comment thread src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.tsx Outdated
@ruanyl
Copy link
Copy Markdown
Member

ruanyl commented Apr 25, 2025

@yyfamazon You also need to update the PR description and add a Changelog entry for it.

@yyfamazon yyfamazon changed the title Add action id to panel item Add action_id, tooltip and disabled to panel item Apr 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@yyfamazon
resolve comment
beee03c 
Signed-off-by: yyfamazon <yyf@amazon.com>
@yyfamazon
Copy link
Copy Markdown
Contributor Author

yyfamazon commented Apr 25, 2025

@yyfamazon You also need to update the PR description and add a Changelog entry for it.

@ruanyl done, thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

ruanyl
ruanyl reviewed Apr 27, 2025
View reviewed changes
Comment thread src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.tsx Outdated
@yyfamazon yyfamazon changed the title Add action_id, tooltip and disabled to panel item Add tooltip and disabled to panel item Apr 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 27, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 27, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@yyfamazon
resolve comments
a2aa8b6 
Signed-off-by: yyfamazon <yyf@amazon.com>
Hailong-am
Hailong-am reviewed Apr 27, 2025
View reviewed changes
Comment thread src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.tsx
Comment on lines +220 to +226
if (typeof action?.getTooltip === 'function') {
contextItem.toolTipContent = action.getTooltip(context);
}
if (typeof action?.isDisabled === 'function') {
contextItem.disabled = action?.isDisabled(context);
}
panels[parentGroupId || 'mainMenu'].items!.push(contextItem);
Copy link
Copy Markdown
Collaborator

@Hailong-am Hailong-am Apr 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like have a unit test for this

@Hailong-am
Copy link
Copy Markdown
Collaborator

Hailong-am commented Apr 29, 2025

failed test cases are not related this change, merge it

@Hailong-am Hailong-am merged commit a37c8ea into opensearch-project:main Apr 29, 2025
67 of 76 checks passed
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request May 13, 2025
@yyfamazon @opensearch-changeset-bot @Qxisylolo
Add tooltip and disabled to panel item (opensearch-project#9696)
340ac83 
* add action id

Signed-off-by: yyfamazon <yyf@amazon.com>

* add change log

Signed-off-by: yyfamazon <yyf@amazon.com>

* add tooltip and disable to context

Signed-off-by: yyfamazon <yyf@amazon.com>

* fix test

Signed-off-by: yyfamazon <yyf@amazon.com>

* fix test

Signed-off-by: yyfamazon <yyf@amazon.com>

* resolve comment

Signed-off-by: yyfamazon <yyf@amazon.com>

* resolve comments

Signed-off-by: yyfamazon <yyf@amazon.com>

* Changeset file for PR opensearch-project#9696 created/updated

---------

Signed-off-by: yyfamazon <yyf@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 3, 2025
@yyfamazon @opensearch-changeset-bot @SuZhou-Joe
Add tooltip and disabled to panel item (opensearch-project#9696)
99ae065 
* add action id

Signed-off-by: yyfamazon <yyf@amazon.com>

* add change log

Signed-off-by: yyfamazon <yyf@amazon.com>

* add tooltip and disable to context

Signed-off-by: yyfamazon <yyf@amazon.com>

* fix test

Signed-off-by: yyfamazon <yyf@amazon.com>

* fix test

Signed-off-by: yyfamazon <yyf@amazon.com>

* resolve comment

Signed-off-by: yyfamazon <yyf@amazon.com>

* resolve comments

Signed-off-by: yyfamazon <yyf@amazon.com>

* Changeset file for PR opensearch-project#9696 created/updated

---------

Signed-off-by: yyfamazon <yyf@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruanyl ruanyl ruanyl approved these changes

@Hailong-am Hailong-am Hailong-am approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@BionIT BionIT Awaiting requested review from BionIT

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

@angle943 angle943 Awaiting requested review from angle943 angle943 is a code owner

@Maosaic Maosaic Awaiting requested review from Maosaic Maosaic is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@d-buckner d-buckner Awaiting requested review from d-buckner d-buckner is a code owner

Assignees

No one assigned

Labels

repeat-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yyfamazon @d-buckner @ruanyl @Hailong-am
⚡