Skip to content

Onboarded opensearch apis to use MDS client when MDS is enabled#1313

Merged
amsiglan merged 1 commit intoopensearch-project:mainfrom
amsiglan:fix-opensearch-apis-for-mds
Nov 12, 2025
Merged

Onboarded opensearch apis to use MDS client when MDS is enabled#1313
amsiglan merged 1 commit intoopensearch-project:mainfrom
amsiglan:fix-opensearch-apis-for-mds

Conversation

@amsiglan
Copy link
Copy Markdown
Collaborator

@amsiglan amsiglan commented Nov 12, 2025

Description

Onboarded opensearch apis to use MDS client when MDS is enabled

Issues Resolved

When calling apis for cluster plugins, settings, the alerting dashboards server is not getting the correct data sourceid and ends up using the wrong client. When multi data source is enabled the data source id passed to the api call from browser needs to be used for resolving the client. This PR fixes that issue

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amsiglan
Onboarded opensearch apis to use MDS client for Neo
6349956 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
@amsiglan amsiglan merged commit 36ccb85 into opensearch-project:main Nov 12, 2025
18 of 29 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
98e825b 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
2a02ac4 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
e39e769 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
c258bdb 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
b5fafed 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
118abc2 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
77718d6 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
791f9e4 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
857f9c9 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313)
77f3dd3 
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 12, 2025
Merged
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1314)
2143ae7 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1315)
b6f9123 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1316)
12d119b 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1317)
2a0e092 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1318)
ee8d7c7 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1319)
bbe9b67 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1320)
58da2bc 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1321)
7c559f7 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1322)
ac9775d 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Nov 13, 2025
@opensearch-trigger-bot @github-actions
Onboarded opensearch apis to use MDS client for Neo (#1313) (#1323)
804a3c4 
cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@tkykenmt tkykenmt mentioned this pull request Jan 11, 2026
Merged
AWSHurneyt pushed a commit that referenced this pull request Feb 2, 2026
@KashKondaka @opensearch-trigger-bot @github-actions
Ppl Alerting (#1333)
b0b970c 
* Add release notes for 3.3.0 (#1293) (#1295)

(cherry picked from commit a232821)

Signed-off-by: opensearch-ci <opensearch-infra@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Bump form-data, cipher-base, sha.js version (#1296) (#1297)

(cherry picked from commit 147e2e7)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Onboarded opensearch apis to use MDS client for Neo (#1313) (#1323)

cr: https://code.amazon.com/reviews/CR-234395069
(cherry picked from commit 36ccb85)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* added v2 apis

add feature flag

add v2 create monitor

fix cypress test

trigger v2 implemented

add monitor details v2

update dashboard pages with v2

fix cypress test

discover flyout and explore dependency added

in progress, broken monitor details

Revert "in progress, broken monitor details"

This reverts commit f2da5e8.

api bug fixes for edit, disable/enable,export as json,delete

finalized edits for monitor detailsv2 page(title still in progress

v2 alerts flyout fixed

added more alert separation, fix v2 alert flyout and pagination

fix duplicate buttons on dashbaord classic

fix double v1/v2 get call for monitor details

remove combined v1/v2 calls in monitor details page

fix buttons in dashboard and monitors pages

set view to classic for v1

create monitor depends on view

fix search monitors call

v2 trigger impl

fix create monitor flyout

fix delete in monitor details page

fix notification validation issue and v2 creation w/ notifs

Parse the monitor payload in V2 to conform with the v1 execute API

remove false failed to load destination toast

fix send test message for alert flyout

fix trigger not loading in v2 monitor edit

allow monitor creation without actions set

dont set default throttle issue when edit/creating

validate on change to true

fix padding in alerting new/classic

update unit tests

refresh monitor list when switching views

remove sequence no and primary term from update monitor call

fix mustache message for notification action

look back window no longer selected when editing monitor w/o lookback

check box disappeared for v1 monitor creation

submitting monitor create wihout trigger name is invalid

add validation error for trigger condition value >=10000

remove debug logs

remove debug logs

use seq no to fix race condition to properly update lookback window

provide clear toast message for invalid ppl query

add look back window to monitor overview stats

fix description layout in monitor detail stats card and change limit to 500 chars

make text labels for fields unclickable on hover

cannot acknowledge monitor in empty classic monitor list

if editing a monitor, do not allow switching monitor view

add info to monitor details v2

add monitor datasource to ppl alert flyout

Revert "add monitor datasource to ppl alert flyout"

This reverts commit a1c7a35.

remove execute ppl on keystroke and add update graph button

graph formatting

small utc formatting fix for look back window

remove comment action from alerts table in monitorv2 details

update unit tests

remove debug logs

remove logs and add helper for dupe code

switch back to euitheme

trigger condition cannot be negative

address comments

get rid of redundant v2 api declaratoin for v2 monitor details

get rid of classic monitor code in v2 file and remove seq no/primary term

Remove acknowledge action from PPL monitor actions and add edit action

Fix improper import causing acknowledge alerts modal to break

cr: https://code.amazon.com/reviews/CR-234635093

Fix action on create monitor from alerts page

cr: https://code.amazon.com/reviews/CR-234678247
Signed-off-by: KashKondaka <37753523+KashKondaka@users.noreply.github.com>

* update unit tests

Signed-off-by: KashKondaka <37753523+KashKondaka@users.noreply.github.com>

---------

Signed-off-by: opensearch-ci <opensearch-infra@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: KashKondaka <37753523+KashKondaka@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riysaxen-amzn riysaxen-amzn riysaxen-amzn approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni

@bowenlan-amzn bowenlan-amzn Awaiting requested review from bowenlan-amzn bowenlan-amzn is a code owner

@rishabhmaurya rishabhmaurya Awaiting requested review from rishabhmaurya rishabhmaurya is a code owner

Assignees

No one assigned

Labels

backport 2.x backport 2.15 backport 2.16 backport 2.17 backport 2.18 backport 2.19 backport 3.0 backport 3.1 backport 3.2 backport 3.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amsiglan @riysaxen-amzn @AWSHurneyt
⚡