Add missing import in TriggerNotifications.js#1345
Merged
eirsep merged 1 commit intoopensearch-project:mainfrom Jan 22, 2026
Merged
Add missing import in TriggerNotifications.js#1345eirsep merged 1 commit intoopensearch-project:mainfrom
eirsep merged 1 commit intoopensearch-project:mainfrom
Conversation
vikhy-aws
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
65 tasks
riysaxen-amzn
approved these changes
Jan 22, 2026
Collaborator
Author
|
Test failures are not related to this change and have been failing for a while which needs separate investigation. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> (cherry picked from commit 0c816e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Mar 25, 2026
(cherry picked from commit 0c816e1) Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a missing import in
TriggerNotifications.jswhich was causing add trigger functionality to fail for composite monitors.Issues Resolved
Fixes failing add trigger functionality in composite monitors (No GitHub issue recorded).
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.