Bug fix in acknowledge alerts modal#1363
Merged
AWSHurneyt merged 1 commit intoopensearch-project:mainfrom Mar 12, 2026
Merged
Conversation
vikhy-aws
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
…alerts Signed-off-by: Sai Vikhyath Kudhroli <vikhy@amazon.com>
vikhy-aws
changed the title
riysaxen-amzn
approved these changes
Mar 11, 2026
Collaborator
|
@vikhy-aws could you confirm whether the cypress tests pass locally for you with this change? Looks like the cypress workflow needs to be reconfigured. |
AWSHurneyt
approved these changes
Mar 11, 2026
Collaborator
AWSHurneyt
left a comment
AWSHurneyt
left a comment
There was a problem hiding this comment.
Approving assuming cypress tests pass locally.
Collaborator
Author
|
Query level monitor tests need a fix, which I'll raise in a separate PR once this is merged so that it can be back-ported easily. Also, the fix is not related to the changes in this PR. All tests passed locally with that test fix. Screenshots attached. 
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in acknowledge alerts modal which was causing the table to stuck in
Loading alerts...state instead of displaying updated alerts.Issues Resolved
#1377
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.