Added workspace ACL checks for Alerting and Monitor APIs#1415
Open
nishtham-amazon wants to merge 3 commits intoopensearch-project:mainfrom
Open
Added workspace ACL checks for Alerting and Monitor APIs#1415nishtham-amazon wants to merge 3 commits intoopensearch-project:mainfrom
nishtham-amazon wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
nishtham-amazon
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
Signed-off-by: nishtham <nishtham@amazon.com>
Signed-off-by: nishtham <nishtham@amazon.com>
huyaboo
reviewed
Apr 17, 2026
Comment on lines
+19
to
+29
| public setWorkspaceStart(workspaceStart: WorkspaceAuthorizer) { | ||
| this.workspaceStart = workspaceStart; | ||
| } | ||
|
|
||
| public setWorkspaceIdGetter(fn: (request: OpenSearchDashboardsRequest) => string | undefined) { | ||
| this.workspaceIdGetter = fn; | ||
| } | ||
|
|
||
| public setLogger(logger: Logger) { | ||
| this.logger = logger; | ||
| } |
Member
There was a problem hiding this comment.
These should be set once at class instantiation time
Signed-off-by: nishtham <nishtham@amazon.com>
nishtham-amazon
requested review from
KashKondaka,
manaswini1920,
toepkerd and
vikhy-aws
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add workspace ACL authorization checks to all Alerting and Monitor server-side APIs to enforce workspace-level access control for OpenSearch Serverless (AOSS) data sources.
Changes:
MDSEnabledClientService.ts— AddedcheckWorkspaceAcl()method that:.aoss.amazonaws.com) data source endpoints; skips for managed domainsx-amzn-aosd-usernameheader and workspace ID from request stateauthorizeWorkspace()via theWorkspacePluginStartcontractWorkspaceAuthorizerinterface (structural typing) to avoid non-public import restrictionssetLogger()for production-ready logging instead ofconsole.logMonitorService.js— Added_enforceWorkspaceAcl()helper and ACL checks to all API methods:createMonitor,createWorkflow,deleteMonitor,deleteWorkflow,updateMonitor,executeMonitor,acknowledgeAlerts,acknowledgeChainedAlerts): requirelibrary_writegetMonitor,getMonitors,getWorkflow,searchMonitors): requirelibrary_writeorlibrary_readAlertService.js— Added same ACL pattern togetAlertsandgetWorkflowAlertsplugin.js— Updatedstart()to inject workspace plugin start contract and logger into all servicesopensearch_dashboards.json— AddedworkspacetooptionalPluginsIssues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check
here.