Fix APM UI paper cuts: pagination, settings modal, and chart improvements#2618
Merged
ps48 merged 3 commits intoopensearch-project:mainfrom Mar 13, 2026
Merged
Fix APM UI paper cuts: pagination, settings modal, and chart improvements#2618ps48 merged 3 commits intoopensearch-project:mainfrom
ps48 merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: ps48 <pshenoy36@gmail.com>
Signed-off-by: ps48 <pshenoy36@gmail.com>
Signed-off-by: ps48 <pshenoy36@gmail.com>
joshuali925
reviewed
Mar 13, 2026
| compressed | ||
| placeholder={i18n.translate('observability.apm.settings.servicesPlaceholder', { | ||
| defaultMessage: 'Select service map dataset', | ||
| defaultMessage: 'Select service map index pattern: otel-v2-apm-service-map-*', |
Member
Author
There was a problem hiding this comment.
yes APM uses service map v2
joshuali925
approved these changes
Mar 13, 2026
TackAdam
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EuiResizableContainerto Services Home, Operations, and Dependencies pages usingReact.memoon table panels to prevent mouse-event re-renders from resettingEuiInMemoryTableuncontrolled pagination statePagination fix (EuiResizableContainer + React.memo)
React.memocomponents (OperationsTablePanel,DependenciesTablePanel,ServicesTablePanel) so resize/mouse events don't re-mount tablesuseRefto capturetogglePanelfrom the render-prop callbackuseCallbackto maintain memo effectivenessAPM Settings modal
Shared component fixes
Issues Resolved
#2545
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.