Fix APM metrics accuracy: server-side filtering, chart totals, and throughput normalization#2623
Merged
ps48 merged 6 commits intoopensearch-project:mainfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: ps48 <pshenoy36@gmail.com>
Signed-off-by: ps48 <pshenoy36@gmail.com>
…umbers Signed-off-by: ps48 <pshenoy36@gmail.com>
Signed-off-by: ps48 <pshenoy36@gmail.com>
Signed-off-by: ps48 <pshenoy36@gmail.com>
joshuali925
reviewed
Mar 24, 2026
| tracesDatasetId: '', | ||
| serviceMapDatasetId: '', | ||
| prometheusDataSourceId: '', | ||
| windowDuration: '60', |
Member
There was a problem hiding this comment.
does any of the saved object attributes type need to change? ApmConfigEntity? would be better to enforce a type on this formData
| } catch { | ||
| return undefined; | ||
| } | ||
| }, [timeRange]); |
Member
There was a problem hiding this comment.
nit. this logic occurred multiple times, better to extract into a function
Member
Author
There was a problem hiding this comment.
moved it to common place useChartStepWindow as a hook
| window?: string | ||
| ): string => | ||
| window | ||
| ? `sum(sum_over_time(request{environment="${environment}",service="${serviceName}",remoteService="${remoteService}",remoteOperation="${remoteOperation}",namespace="span_derived",remoteService!=""}[${window}]))` |
Member
There was a problem hiding this comment.
remoteService!="" is unnecessary?
Member
Author
There was a problem hiding this comment.
yes, this is unnecessary and removed it.
| ':' + | ||
| ('0' + date.getUTCSeconds()).slice(-2) + | ||
| '.' + | ||
| ('00' + date.getUTCMilliseconds()).slice(-3) |
Member
There was a problem hiding this comment.
is there existing code to do this?
Member
Author
There was a problem hiding this comment.
OSD core has this in query_enhancements/common/utils.ts. formatDate is similar but uses local time, not UTC
TackAdam
reviewed
Mar 24, 2026
public/components/apm/shared/components/service_map/edge_metrics_flyout.tsx
Outdated
Show resolved
Hide resolved
TackAdam
reviewed
Mar 24, 2026
public/components/apm/shared/components/service_map/service_details_panel.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ps48 <pshenoy36@gmail.com>
TackAdam
approved these changes
Mar 24, 2026
joshuali925
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#2545
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.