Fix NPE in sanitizeMetricName when unit or aggregationTemporality is …#6687
Merged
dlvenable merged 6 commits intoopensearch-project:mainfrom Apr 2, 2026
Merged
Conversation
…null Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
srikanthpadakanti
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
1 task
dlvenable
requested changes
Mar 31, 2026
Member
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thanks @srikanthpadakanti !
...in/java/org/opensearch/dataprepper/plugins/sink/prometheus/service/PrometheusTimeSeries.java
Show resolved
Hide resolved
added 3 commits
March 31, 2026 11:16
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
dlvenable
previously approved these changes
Mar 31, 2026
Member
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thank you @srikanthpadakanti for this fix!
kkondaka
reviewed
Mar 31, 2026
...in/java/org/opensearch/dataprepper/plugins/sink/prometheus/service/PrometheusTimeSeries.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 31, 2026 15:06
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
dlvenable
approved these changes
Apr 1, 2026
Member
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thanks @srikanthpadakanti !
kkondaka
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix NPE in
PrometheusTimeSeries.sanitizeMetricName()whenunitoraggregationTemporalityis null.Issues Resolved
Resolves #6683
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.