Fix documentErrors metric incorrectly counting version conflict error…#6758
Open
Keyur-S-Patel wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
opensearch-project#5376) In BulkRetryStrategy.handleFailures(), documentErrorsCounter was incremented for all item errors including version conflicts. Version conflicts are not true errors — they indicate the latest document already exists in OpenSearch and are not sent to DLQ. Moved documentErrorsCounter.increment() and getDocumentStatusCounter() into the else branch so they only fire for actual non-retryable failures, matching the existing behavior in createBulkRequestForRetry(). Added unit test to verify version conflicts increment only the documentsVersionConflictErrors metric and not documentErrors. Signed-off-by: Keyur-S-Patel <keyurpatel.opensource@gmail.com>
Keyur-S-Patel
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
BulkRetryStrategy.handleFailures(), thedocumentErrorsCounterwas being incremented for all item-level errors, including version conflict errors. Version conflict errors are not true document errors — they indicate the latest version of the document already exists in OpenSearch and are not sent to the DLQ. This caused thedocumentErrorsmetric to be inflated, creating a confusing user experience.This change moves
documentErrorsCounter.increment()andgetDocumentStatusCounter().increment()into theelsebranch so they only fire for actual non-retryable failures, skipping version conflicts. This matches the existing behavior already present increateBulkRequestForRetry(). A unit test was added to verify that version conflicts only incrementdocumentsVersionConflictErrorsand notdocumentErrors.Issues Resolved
Resolves #5376
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/data-prepper/blob/main/CONTRIBUTING.md).