Skip to content

Fix add agentic memory API#10870

Merged
natebower merged 2 commits intoopensearch-project:mainfrom
nathaliellenaa:agentic_memory_fix
Sep 3, 2025
Merged

Fix add agentic memory API#10870
natebower merged 2 commits intoopensearch-project:mainfrom
nathaliellenaa:agentic_memory_fix

Conversation

@nathaliellenaa
Copy link
Copy Markdown
Contributor

Description

Fix add agentic memory API request body and add more information into the request fields table.

Issues Resolved

Closes #10867

Version

3.2

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Field | Data type | Required/Optional | Description
:--- | :--- | :--- | :---
`messages` | List | Required | A list of messages.
`messages` | List | Required | A list of messages. Each message requires `content` and may include a `role` (commonly `user` or `assistant`).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is role mandatory or optional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

role is optional when infer=true

Copy link
Copy Markdown
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nathaliellenaa! One suggestion.

@kolchfa-aws kolchfa-aws added backport 3.2 Doc review PR: Doc review in progress labels Sep 2, 2025
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@nathaliellenaa
Copy link
Copy Markdown
Contributor Author

Thanks @kolchfa-aws! Addressed the comment

@kolchfa-aws kolchfa-aws added Editorial review and removed Doc review PR: Doc review in progress labels Sep 3, 2025
Copy link
Copy Markdown
Contributor

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower merged commit e15e37f into opensearch-project:main Sep 3, 2025
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2025
* Fix add memory

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Address comment

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

---------

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
(cherry picked from commit e15e37f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Agentic memory: add memory example not working

4 participants