add Yandex Cloud embeddings connector blueprint#4469
add Yandex Cloud embeddings connector blueprint#4469mkhludnev wants to merge 6 commits intoopensearch-project:mainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughFixed formatting in the standard blueprints README and added a new Yandex Cloud AI Studio embeddings legacy blueprint documenting connector configuration, model registration, deployment, and example inference payloads and responses. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/remote_inference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/remote_inference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md
[grammar] ~120-~120: Ensure spelling is correct
Context: ...of life?" } } Sample response of Yadex Cloud AI Studio Embedding: json { ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: spotless
🔇 Additional comments (1)
docs/remote_inference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md (1)
45-46: Verify pre/post-processing functions are correct for Yandex Cloud.The connector references
bedrockpre/post-processing functions, but this blueprint is for Yandex Cloud. Verify that these processing functions are:
- Generic/universal and work correctly with Yandex Cloud API responses, or
- Should be replaced with Yandex-specific processing functions.
If these are not the correct functions for Yandex Cloud, update them accordingly.
...ference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md
Outdated
Show resolved
Hide resolved
...ference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/remote_inference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md(1 hunks)
🔇 Additional comments (1)
docs/remote_inference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md (1)
45-46: Clarify why Bedrock pre/post-processing functions are used for Yandex Cloud.The pre/post-processing functions reference
bedrockfor a Yandex Cloud connector. Clarify whether Yandex's request/response format is compatible with Bedrock's processing, or if Yandex-specific processing functions should be used instead.If compatibility is intentional, add a brief comment explaining why Bedrock functions are appropriate here. If these should be Yandex-specific, update them accordingly.
...ference_blueprints/standard_blueprints/yandexcloud_connector_embedding_standard_blueprint.md
Show resolved
Hide resolved
10153a1 to
3824d45
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @docs/remote_inference_blueprints/standard_blueprints/README.md:
- Around line 50-54: The "Yandex Cloud:" provider entry in the README uses a
trailing colon which is inconsistent with other provider headings (Bedrock,
Cohere, OpenAI, VertexAI); edit the README to remove the colon so the line reads
"Yandex Cloud" and keep the existing link text and indentation unchanged to
match the established pattern.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/remote_inference_blueprints/standard_blueprints/README.mddocs/remote_inference_blueprints/yandexcloud_connector_embedding_legacy_blueprint.md
✅ Files skipped from review due to trivial changes (1)
- docs/remote_inference_blueprints/yandexcloud_connector_embedding_legacy_blueprint.md
🔇 Additional comments (1)
docs/remote_inference_blueprints/standard_blueprints/README.md (1)
50-51: VertexAI formatting corrected.The formatting fix on the VertexAI entry (removing the extra leading dash) aligns it properly with other provider entries in the legacy blueprints section. The change looks good.
|
@mingshl may I ask your attention? |
mingshl
left a comment
There was a problem hiding this comment.
LGTM, thanks @mkhludnev .
@b4sjoo can you also take a look?
|
@b4sjoo please elaborate. |
PR Reviewer Guide 🔍(Review updated until commit a79f3bb)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to a79f3bb Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit c45bb98
Suggestions up to commit 59496d6
Suggestions up to commit ce3d129
Suggestions up to commit 0f8ac3d
Suggestions up to commit f22dac1
|
|
Persistent review updated to latest commit f22dac1 |
| } | ||
| ``` | ||
|
|
||
| Note: Replace all `<placeholders>` in the preceding code snippet with appropriate values, while preserving `${curly braces}` syntax exactly as shown. Short-lived [bearer tokens](https://yandex.cloud/en/docs/iam/concepts/authorization/iam-token) (valid ~12 hours) may be used as an alternative to [API keys](https://yandex.cloud/en/docs/iam/concepts/authorization/api-key). API keys must be granted either `yc.ai.languageModels.execute` or `yc.ai.foundationModels.execute` roles. Also refer to [the guide](https://yandex.cloud/en/docs/ai-studio/security/). Additionally, due to distinct [models](https://yandex.cloud/en/docs/ai-studio/concepts/embeddings) being employed for query processing versus document processing, two dedicated connectors are required. Using these particular pre/post processing functions is crucial. |
There was a problem hiding this comment.
Thanks for the contribution! One suggestion: the note mentions that two dedicated connectors are required (one for text-search-doc and one for text-search-query), but the blueprint only walks through creating a
single connector. Since this is meant to be a step-by-step guide, could we either:
- Show both connector configs explicitly (e.g., "Step 2a: Create connector for document embedding" and "Step 2b: Create connector for query embedding"), or
- At minimum, move the two-connector requirement out of the note paragraph and into a clearly labeled step
There was a problem hiding this comment.
You’re right. I’d prefer not to repeat nearly identical JSON snippets and turn it into a “spot the difference” exercise, so I tried to balance explicitness with verbosity.
Do you think the current level of detail is sufficient?
Also, would you be OK with using “2d” and “2q” as sub-step labels? They’re ordered and (I think) self-explanatory.
|
Persistent review updated to latest commit 0f8ac3d |
|
Persistent review updated to latest commit ce3d129 |
|
Persistent review updated to latest commit 59496d6 |
|
Failed to generate code suggestions for PR |
add Yandex Cloud embeddings connector blueprint Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
|
Failed to generate code suggestions for PR |
|
Persistent review updated to latest commit c45bb98 |
|
@dhrubo-os may I ask your attention? |
|
Persistent review updated to latest commit a79f3bb |
Description
This contributes connector blueprint for Yandex Cloud.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Note for reviews
I've contributed to OpenSearch before.
And thanks for reviewing it!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.