Wired Up Reporting to Shim by akshay2000 · Pull Request #2689 · opensearch-project/opensearch-migrations

akshay2000 · 2026-04-13T08:57:35Z

Description

Wires the existing MetricsReceiver and ReportingSink into MultiTargetRoutingHandler so every dual-target request automatically produces a ValidationDocument with hit-count drift, latency delta, and optional request/response bodies. Reporting is enabled via a --reportingConfig JSON CLI flag and is wired into the dev sandbox dual-target shims. All new constructor params default to null for backward compatibility.

Testing

Unit tests

Check List

New functionality includes testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov · 2026-04-13T08:59:06Z

Codecov Report

❌ Patch coverage is 85.13514% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.46%. Comparing base (abe6949) to head (91de63e).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
...opensearch/migrations/transform/shim/ShimMain.java	76.92%	2 Missing and 7 partials ⚠️
...ransform/shim/netty/MultiTargetRoutingHandler.java	92.30%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2689      +/-   ##
============================================
+ Coverage     73.28%   73.46%   +0.17%     
  Complexity      106      106              
============================================
  Files           721      721              
  Lines         33372    33441      +69     
  Branches       2910     2915       +5     
============================================
+ Hits          24457    24566     +109     
+ Misses         7582     7535      -47     
- Partials       1333     1340       +7

Flag	Coverage Δ
gradle	`69.89% <85.13%> (+0.26%)`	⬆️
node	`90.97% <ø> (ø)`
python	`77.77% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

...ture/transformationShim/src/main/java/org/opensearch/migrations/transform/shim/ShimMain.java

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

AndreKurait · 2026-04-14T17:13:57Z

.../src/main/java/org/opensearch/migrations/transform/shim/netty/MultiTargetRoutingHandler.java

            Map<String, Object> responseRequestMap = hasCursorMark ? targetRequestMap : requestMap;
            futures.put(name, dispatchToTarget(target, targetRequestMap, responseRequestMap, dispatchCtx));
+
+            collectTransformData(target, name, targetRequestMap,


How is metricsMap not empty at this point? I would expect the responses are async and we have to wait on futures before the responses are populated

The metrics are coming from the request translations. For example, if a request translation notices some limitation, (like offsets not being supported by OpenSearch inside aggregation buckets) the transform will emit a metric. So the metrics will be available as soon as the request transform is run and we come back from GraalVM.

The pr overview here says

so every dual-target request automatically produces a ValidationDocument with hit-count drift, latency delta, and optional request/response bodies.

Is this accurate?

That is correct. (Obviously the user must pass --reportingConfig to enable this.) The list is not exhaustive. Do you see an accuracy issue here?

Signed-off-by: Andre Kurait <akurait@amazon.com>

…ures Signed-off-by: Andre Kurait <akurait@amazon.com>

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

akshay2000 had a problem deploying to migrations-cicd-require-approval April 13, 2026 08:57 — with GitHub Actions Error

akshay2000 force-pushed the reporting-wiring branch from 35d5751 to c4e3547 Compare April 13, 2026 09:10

akshay2000 had a problem deploying to migrations-cicd-require-approval April 13, 2026 09:10 — with GitHub Actions Error

akshay2000 had a problem deploying to migrations-cicd-require-approval April 13, 2026 09:43 — with GitHub Actions Error

akshay2000 had a problem deploying to migrations-cicd-require-approval April 13, 2026 10:45 — with GitHub Actions Error

akshay2000 added 3 commits April 14, 2026 10:00

Wired up reporting to shim.

33ba53d

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

Attempting to increase the coverage

cce335d

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

Further attempting to increase the coverage

5b2d393

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

akshay2000 force-pushed the reporting-wiring branch from 94e338e to 5b2d393 Compare April 14, 2026 04:43

akshay2000 had a problem deploying to migrations-cicd-require-approval April 14, 2026 04:43 — with GitHub Actions Error

More coverage

5d6f589

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

akshay2000 had a problem deploying to migrations-cicd-require-approval April 14, 2026 05:24 — with GitHub Actions Error

akshay2000 marked this pull request as ready for review April 14, 2026 05:39

akshay2000 requested review from AndreKurait, gregschohn, jugal-chauhan and sumobrian as code owners April 14, 2026 05:39

niravpi reviewed Apr 14, 2026

View reviewed changes

...ture/transformationShim/src/main/java/org/opensearch/migrations/transform/shim/ShimMain.java Outdated Show resolved Hide resolved

akshay2000 had a problem deploying to migrations-cicd-require-approval April 14, 2026 14:28 — with GitHub Actions Error

niravpi approved these changes Apr 14, 2026

View reviewed changes

Added validation on the type of sink.

56f2fc1

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

akshay2000 force-pushed the reporting-wiring branch from a8588ff to 56f2fc1 Compare April 14, 2026 15:18

akshay2000 had a problem deploying to migrations-cicd-require-approval April 14, 2026 15:18 — with GitHub Actions Error

AndreKurait reviewed Apr 14, 2026

View reviewed changes

AndreKurait approved these changes Apr 15, 2026

View reviewed changes

Merge branch 'main' into reporting-wiring

39da623

Signed-off-by: Andre Kurait <akurait@amazon.com>

AndreKurait had a problem deploying to migrations-cicd-require-approval April 15, 2026 02:22 — with GitHub Actions Error

AndreKurait enabled auto-merge April 15, 2026 02:22

Fix compilation error: use dispatchResult.futures instead of bare fut…

987eb58

…ures Signed-off-by: Andre Kurait <akurait@amazon.com>

AndreKurait had a problem deploying to migrations-cicd-require-approval April 15, 2026 02:45 — with GitHub Actions Error

AndreKurait approved these changes Apr 15, 2026

View reviewed changes

akshay2000 had a problem deploying to migrations-cicd-require-approval April 15, 2026 04:27 — with GitHub Actions Error

Fixed broken test

91de63e

Signed-off-by: Akshay Zade <zadaksha@amazon.com>

akshay2000 force-pushed the reporting-wiring branch from 827f375 to 91de63e Compare April 15, 2026 04:41

akshay2000 requested a deployment to migrations-cicd-require-approval April 15, 2026 04:41 — with GitHub Actions Waiting

AndreKurait merged commit 8bd941c into opensearch-project:main Apr 15, 2026
69 of 71 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wired Up Reporting to Shim#2689

Wired Up Reporting to Shim#2689
AndreKurait merged 8 commits intoopensearch-project:mainfrom
akshay2000:reporting-wiring

akshay2000 commented Apr 13, 2026 •

edited

Loading

Uh oh!

codecov bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

AndreKurait Apr 14, 2026

Uh oh!

akshay2000 Apr 14, 2026

Uh oh!

AndreKurait Apr 14, 2026 •

edited

Loading

Uh oh!

akshay2000 Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

akshay2000 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Check List

Uh oh!

codecov bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

AndreKurait Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

akshay2000 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

AndreKurait Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akshay2000 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akshay2000 commented Apr 13, 2026 •

edited

Loading

codecov bot commented Apr 13, 2026 •

edited

Loading

AndreKurait Apr 14, 2026 •

edited

Loading