Add shard_fetch_with_source_count metric#931
Open
shivamg2017 wants to merge 1 commit intoopensearch-project:mainfrom
Open
Add shard_fetch_with_source_count metric#931shivamg2017 wants to merge 1 commit intoopensearch-project:mainfrom
shivamg2017 wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
shivamg2017
requested review from
Gaganjuneja,
Shephalimittal,
ansjcy,
khushbr,
nishchay21,
psychbot,
rramachand21 and
sbcd90
as code owners
Gaganjuneja
reviewed
Apr 2, 2026
| try { | ||
| if (searchContext.fetchSourceContext() != null | ||
| && searchContext.fetchSourceContext().fetchSource()) { | ||
| shardFetchWithSourceCounter.add(1, createTags(searchContext)); |
Collaborator
There was a problem hiding this comment.
Do we need shardId as dimension?
Author
There was a problem hiding this comment.
Removed — shard_id just adds cardinality without value.
| return; | ||
| } | ||
| try { | ||
| if (searchContext.fetchSourceContext() != null |
Collaborator
There was a problem hiding this comment.
Can't we use context.sourceRequested()?
| private final Counter shardFetchWithSourceCounter; | ||
| private final int numProcessors; | ||
|
|
||
| public static final String SHARD_FETCH_WITH_SOURCE_COUNT = "shard_fetch_with_source_count"; |
Collaborator
There was a problem hiding this comment.
Can we name it query_source_fetch_count?
shivamg2017
force-pushed
the
is-source-created
branch
from
b738d57 to
119ab9d
Compare
Gaganjuneja
reviewed
Apr 8, 2026
| 1, createIndexTags(searchContext)); | ||
| } | ||
| } catch (Exception e) { | ||
| LOG.debug("Error emitting query_source_fetch_count metric", e); |
| private final Counter shardFetchWithSourceCounter; | ||
| private final int numProcessors; | ||
|
|
||
| public static final String QUERY_SOURCE_FETCH_COUNT = "query_source_fetch_count"; |
Collaborator
There was a problem hiding this comment.
nit: let;s change to query_source_hits.
Collaborator
|
ADD UTs as well. |
shivamg2017
force-pushed
the
is-source-created
branch
from
996eebb to
efe5f2e
Compare
Author
Added |
Gaganjuneja
approved these changes
Apr 15, 2026
Collaborator
|
Please fix DCO. |
Signed-off-by: Shivam Gupta <gshhivam@amazon.com>
shivamg2017
force-pushed
the
is-source-created
branch
from
efe5f2e to
ea806ac
Compare
Gaganjuneja
approved these changes
Apr 17, 2026
nishchay21
reviewed
Apr 17, 2026
| return; | ||
| } | ||
| try { | ||
| if (searchContext.sourceRequested()) { |
Collaborator
There was a problem hiding this comment.
This is shard level correct so we will send counter as 1 for all shards. ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add shard_fetch_with_source_count metric. This will emit a counter on fetch phase when source is requested.
ImmutableMetricData{resource=Resource{schemaUrl=null, attributes={service.name="OpenSearch"}}, instrumentationScopeInfo=InstrumentationScopeInfo{name=org.opensearch.telemetry, version=null, schemaUrl=null, attributes={}}, name=shard_fetch_with_source_count, description=Count of shard fetch phases where _source was requested, unit=count, type=DOUBLE_SUM, data=ImmutableSumData{points=[ImmutableDoublePointData{startEpochNanos=1774959167219102530, epochNanos=1774959227218847618, attributes={index_name="test-index", index_uuid="LlP0tKOESyi5Bq7IVi0sDw", shard_id=0}, value=1.0, exemplars=[]}], monotonic=true, aggregationTemporality=DELTA}}