Upgrade ssh_connection_hash from SHA1 to SHA256#595
Open
xnox wants to merge 1 commit intoopenssh:masterfrom
Open
Upgrade ssh_connection_hash from SHA1 to SHA256#595xnox wants to merge 1 commit intoopenssh:masterfrom
xnox wants to merge 1 commit intoopenssh:masterfrom
Conversation
xnox
force-pushed
the
session-sha256-v2
branch
from
12c8ace to
f200754
Compare
Upgrade ssh_connection_hash from SHA1 to SHA256. Due to increased length, instead of using hex encoding, use base64url encoding, which for SHA256 is only slightly longer than hex SHA1. This change enables building and using ssh completely without SHA1.
xnox
force-pushed
the
session-sha256-v2
branch
from
f200754 to
265fc7b
Compare
|
base85(sha256(foo)) should be exactly the size of hex(sha1(foo)), is this an option? |
Author
From mailing lists, one of the requirements that it has to be URL and file-system safe name, base85 seems to use \ and / which are not safe on filesystems - things can fail with "no such directory" because of slashes. |
I see, then nevermind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade ssh_connection_hash from SHA1 to SHA256. Due to increased
length, instead of using hex encoding, use base64url encoding, which
for SHA256 is only slightly longer than hex SHA1.
This change enables building and using ssh completely without SHA1.