ssh_systemd_notify: remove pretended abstract unix sockets "support"#615
ssh_systemd_notify: remove pretended abstract unix sockets "support"#615turistu wants to merge 2 commits intoopenssh:masterfrom
Conversation
as per https://lwn.net/Articles/993705/ and while at it, git rid of some prissy cargo-cult too
|
If there's a bug in the implementation then I'd rather it be fixed rather than removed.
This is unhelpful language. |
Of course, you're not telling what "fixing" it would entail -- but neither accepting just a subset a unix-domain abstract sockets addresses (e.g. those who contain just a single nul byte), nor adding and documenting an ad-hoc string escaping mechanism (just for the sake of sending a literal
Ok, keep it broken then |
That's pointless and broken. Pointless because one would have to compile a modified systemd in order to use an abstract address for the notify socket, so it's not serving any real-life purpose. Broken because that would only accept an arbitrary subset of abstract socket addresses, namely only those that do not contain more than a single nul byte. So it's not even worth as example code. |
as per https://lwn.net/Articles/993705/
and while at it, git rid of some prissy cargo-cult too