Open
Conversation
DemiMarie
force-pushed
the
ipv6-addresses
branch
from
03515fa to
743134c
Compare
DemiMarie
force-pushed
the
ipv6-addresses
branch
from
743134c to
acb1dda
Compare
Asongwed
approved these changes
Feb 4, 2026
djmdjm
reviewed
Feb 6, 2026
DemiMarie
force-pushed
the
ipv6-addresses
branch
from
acb1dda to
3dffcf1
Compare
Author
|
The memory safety of the new code is slightly non-trivial. If |
Author
|
@djmdjm Would it be possible to get a re-review? |
DemiMarie
force-pushed
the
ipv6-addresses
branch
from
3dffcf1 to
e159fa5
Compare
URLs didn't distinguish between IPv6 addresses and domain names, so a bracketed IPv6 address was treated as a syntax error. Fix this by parsing them properly. The parser also handles percent-encoded zone IDs and properly percent-decodes them. Full regression tests are included.
DemiMarie
force-pushed
the
ipv6-addresses
branch
from
e159fa5 to
6bdf58b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLs didn't distinguish between IPv6 addresses and domain names, so a bracketed IPv6 address was treated as a syntax error. Fix this by parsing them properly. The parser also handles percent-encoded zone IDs and properly percent-decodes them.
Full regression tests are included.