vm.yml: fix solaris PAM tests and add retry for VM hangs#643
Open
renaudallard wants to merge 1 commit intoopenssh:masterfrom
Open
vm.yml: fix solaris PAM tests and add retry for VM hangs#643renaudallard wants to merge 1 commit intoopenssh:masterfrom
renaudallard wants to merge 1 commit intoopenssh:masterfrom
Conversation
Add missing SSHD_CONFOPTS="UsePam yes" to the solaris PAM test step so it actually tests PAM functionality instead of re-running the default tests with a PAM-enabled binary. The Solaris QEMU VM intermittently hangs during tests (a VM-level issue also affecting upstream master). Add retry logic: each test step has a 30-minute timeout with continue-on-error, followed by a retry step that runs if the first attempt failed. This handles the intermittent hang rate reliably without masking real test failures. Tested successfully 7 times in a row (including runs where the retry mechanism was exercised after a VM hang).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing SSHD_CONFOPTS="UsePam yes" to the solaris PAM test step so it actually tests PAM functionality instead of re-running the default tests with a PAM-enabled binary.
The Solaris QEMU VM intermittently hangs during tests (a VM-level issue also affecting upstream master). Add retry logic: each test step has a 30-minute timeout with continue-on-error, followed by a retry step that runs if the first attempt failed. This handles the intermittent hang rate reliably without masking real test failures.
Tested successfully 7 times in a row (including runs where the retry mechanism was exercised after a VM hang).