Open
Conversation
added 2 commits
March 31, 2026 09:09
The commit 683d0ab introduced a conversion issue, which converted "MaxStartups 3" into "10:30:3". This is wrong, as value1 > value3 and it causes side effects leading to crash of sshd when Maxstartups functionality is triggered with this error: "error: mm_reap: child terminated by signal 15" This commit reverts to previous behavior. Fixes: 683d0ab (upstream: Make MaxStartups and PerSourceNetBlockSize first-match-wins, 2025-09-01)
Reducing the amount of nested if statements and combining all plausibility checks to one place. This improves readability and simplifies the code for easier maintenance.
xypiie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 683d0ab introduced a conversion issue, which converted
"MaxStartups 3" into "10:30:3". This is wrong, as value1 > value3 and
it causes side effects leading to crash of sshd when MaxStartups
functionality is triggered with this error:
"error: mm_reap: child terminated by signal 15"
Please find fix proposal and a proposal for refactoring the parsing part to be more robust against such issues.