Fix error handling in fill_default_options#649
Open
ZoltanFridrich wants to merge 1 commit intoopenssh:masterfrom
Open
Fix error handling in fill_default_options#649ZoltanFridrich wants to merge 1 commit intoopenssh:masterfrom
ZoltanFridrich wants to merge 1 commit intoopenssh:masterfrom
Conversation
Signed-off-by: Zoltan Fridrich <zfridric@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a bug investigation in CentOS 10 where our downstream patch removes kex algorithm in FIPS mode but ignores the error when encountered in
kex_names_validon purpose. This propagated the error further eventually hitting an error infill_default_optionsbut instead of exiting, the error is ignored and ssh keeps running in broken state.This seems to be a bug in upstream code where
retis never set infill_default_optionseven when error is encountered.Looking at the history the
rvariable was introduced in commit 1b9dd4a where the error was fatal. Then in commit 43026da the error handling was moved outside of the function. The commit introducedretvariable which is never assigned into. This makes the function always return 0, even on error.