Skip to content

Improve combobox dropdown styling to give labels more room and readability#10127

Merged
tyrasd merged 3 commits intoopenstreetmap:developfrom
tordans:field-table-width-linebreak
Feb 26, 2024
Merged

Improve combobox dropdown styling to give labels more room and readability#10127
tyrasd merged 3 commits intoopenstreetmap:developfrom
tordans:field-table-width-linebreak

Conversation

@tordans
Copy link
Copy Markdown
Collaborator

@tordans tordans commented Feb 25, 2024

Local test URL

A few screenshots:

  • image
  • image

Longer translations keys are not readable with ellipsis and the tooltip only shows the description (or fallback), not the title.

This change makes long use line breaks with small line height to make the whole text visible.
We use it like a div, so no reason to not use one.
The flex box solution gave a lot of space to the label. This solution minimizes that space to give more space to the values dropdown.
@tordans tordans requested a review from tyrasd February 25, 2024 10:37
@tyrasd tyrasd added the usability An issue with ease-of-use or design label Feb 25, 2024
@tyrasd tyrasd merged commit ce51b33 into openstreetmap:develop Feb 26, 2024
bhousel added a commit to facebook/Rapid that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

usability An issue with ease-of-use or design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants